You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/04/06 02:06:31 UTC

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #5592: [Metrics][LOG] Update metrics of 'max_compaction_score' and log for compaction

yangzhg commented on a change in pull request #5592:
URL: https://github.com/apache/incubator-doris/pull/5592#discussion_r607437773



##########
File path: be/src/olap/tablet_manager.cpp
##########
@@ -681,7 +681,7 @@ void TabletManager::get_tablet_stat(TTabletStatResult* result) {
 
 TabletSharedPtr TabletManager::find_best_tablet_to_compaction(
         CompactionType compaction_type, DataDir* data_dir,
-        std::vector<TTabletId>& tablet_submitted_compaction) {
+        std::vector<TTabletId>& tablet_submitted_compaction, uint32_t& score) {

Review comment:
       use  a pointer instead




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org