[jira] [Commented] (AIRFLOW-4385) Add namespace into pod's yaml

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013507#comment-17013507 ] 

ASF GitHub Bot commented on AIRFLOW-4385:
-----------------------------------------

stale[bot] commented on pull request #5152: [AIRFLOW-4385] Add namespace into pod's yaml
URL: https://github.com/apache/airflow/pull/5152
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add namespace into pod's yaml
> -----------------------------
>
>                 Key: AIRFLOW-4385
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4385
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: executors, worker
>            Reporter: Nikolay
>            Assignee: Nikolay
>            Priority: Major
>              Labels: kubernetes
>         Attachments: pods_logs.txt
>
>
> During integration phase between Airflow and VerticalPodAutoscaler (link: [https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler]) i stumbled into an issue when VerticalPodAutoscaler library doesn't work for Airflow worker pods. 
> How VerticalPodAutoscaler produces resource recommendations:
> - monitor newly created pods
> - compare newly created pods with existing configuration (compare by label and namespace)
> - provide new recommendations if configuration exists for pod
>  VerticalPodAutoscaler finds all created pods by label, but namespace comparison fails every time. I did some investigation and realise that when airflow calls a kubernetes api, it passes yaml file without +metadata.namespace+ property. Go libraries can deserialise this yaml, but there is no information about namespace.
> Attaching logs from VerticalPodAutoscaler, there you can see how airflow pod was deserialised (namespace is missing). Works for custom pod.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)