You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/10/01 01:26:56 UTC
[PR] fix: [branch-1.1] coerce native IF branches to a common type (#6458) [datafusion-comet]
andygrove opened a new pull request, #6491:
URL: https://github.com/apache/datafusion-comet/pull/6491
## Which issue does this PR close?
Refs #6334 and #6402. Selective backport of pending upstream #6458 (4101f81); upstream has not merged.
## Rationale for this change
Coerce native IF branches to their common Arrow type, preserving nested field names and nullability, so valid Spark expressions return correctly typed results.
## What changes are included in this PR?
Port the IF correction and final upstream coverage, including complementary two-field structs, arrays of structs, structs containing arrays/maps, and the timezone-label unit test. Keep the helper in the existing release if_expr module: branch-1.1 lacks the main-only CASE WHEN refactor, which is intentionally excluded. Existing release CASE WHEN behavior is unchanged.
## How are these changes tested?
Fresh native build and all five selected native conditional tests passed. JDK 17/default Spark 4.1: if_nested_nullability SQL fixture and the selected CometMapExpressionSuite IF regression passed. Full cross-version release CI pending. `git diff --check` passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: [branch-1.1] coerce native IF branches to a common type (#6458) [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #6491:
URL: https://github.com/apache/datafusion-comet/pull/6491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org