You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/12 12:41:50 UTC

[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #7076: Remove duplicate calls and optimize compilation speed

hartmannathan commented on code in PR #7076:
URL: https://github.com/apache/incubator-nuttx/pull/7076#discussion_r968367957


##########
tools/Config.mk:
##########
@@ -555,26 +555,34 @@ endef
 
 # ARCHxxx means the predefined setting(either toolchain, arch, or system specific)
 
-ARCHDEFINES += ${shell $(DEFINE) "$(CC)" __NuttX__}
+ifndef DEFINE_PREFIX
+export DEFINE_PREFIX:= $(subst __DEF__,,${shell $(DEFINE) "$(CC)" "__DEF__"})

Review Comment:
   Should have space before `:=`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org