You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Stefan Seelmann (JIRA)" <ji...@apache.org> on 2007/04/01 17:57:32 UTC
[jira] Created: (DIRSERVER-891) ACIItemSyntaxChecker accepts
incomplete or invalid ACI Items
ACIItemSyntaxChecker accepts incomplete or invalid ACI Items
------------------------------------------------------------
Key: DIRSERVER-891
URL: https://issues.apache.org/jira/browse/DIRSERVER-891
Project: Directory ApacheDS
Issue Type: Bug
Reporter: Stefan Seelmann
The ACIItemSyntaxChecker accepts incomplete or invalid ACI Items.
1.) An ACI item with the following protected item isn't rejected: "...attributeValue { must_be_a_name_value_pair }..."
2.) Incomplete ACIs like "{ identificationTag "id2" }" aren't rejected
I add some commented test cases to ACIItemSyntaxCheckerTest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-891) ACIItemSyntaxChecker accepts
incomplete or invalid ACI Items
Posted by "Ersin Er (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ersin Er updated DIRSERVER-891:
-------------------------------
Fix Version/s: (was: 1.5.2)
1.5.1
> ACIItemSyntaxChecker accepts incomplete or invalid ACI Items
> ------------------------------------------------------------
>
> Key: DIRSERVER-891
> URL: https://issues.apache.org/jira/browse/DIRSERVER-891
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.5.0
> Reporter: Stefan Seelmann
> Assignee: Ersin Er
> Fix For: 1.5.1
>
>
> The ACIItemSyntaxChecker accepts incomplete or invalid ACI Items.
> 1.) An ACI item with the following protected item isn't rejected: "...attributeValue { must_be_a_name_value_pair }..."
> 2.) Incomplete ACIs like "{ identificationTag "id2" }" aren't rejected
> I add some commented test cases to ACIItemSyntaxCheckerTest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-891) ACIItemSyntaxChecker accepts
incomplete or invalid ACI Items
Posted by "Ersin Er (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485951 ]
Ersin Er commented on DIRSERVER-891:
------------------------------------
Is this because of misbehavior of the ACIItem Parser?
> ACIItemSyntaxChecker accepts incomplete or invalid ACI Items
> ------------------------------------------------------------
>
> Key: DIRSERVER-891
> URL: https://issues.apache.org/jira/browse/DIRSERVER-891
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.5.0
> Reporter: Stefan Seelmann
>
> The ACIItemSyntaxChecker accepts incomplete or invalid ACI Items.
> 1.) An ACI item with the following protected item isn't rejected: "...attributeValue { must_be_a_name_value_pair }..."
> 2.) Incomplete ACIs like "{ identificationTag "id2" }" aren't rejected
> I add some commented test cases to ACIItemSyntaxCheckerTest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-891) ACIItemSyntaxChecker accepts
incomplete or invalid ACI Items
Posted by "Alex Karasulu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509419 ]
Alex Karasulu commented on DIRSERVER-891:
-----------------------------------------
Perhaps we should fix this sooner rather than later because it could result in some undefined behavior. If Ersin can find the fix quickly since he understands this code best then perhaps we should shove it into 1.5.1. If the fix is not apparent and will take more time we can postpone it to 1.5.2.
> ACIItemSyntaxChecker accepts incomplete or invalid ACI Items
> ------------------------------------------------------------
>
> Key: DIRSERVER-891
> URL: https://issues.apache.org/jira/browse/DIRSERVER-891
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.5.0
> Reporter: Stefan Seelmann
> Fix For: 1.5.2
>
>
> The ACIItemSyntaxChecker accepts incomplete or invalid ACI Items.
> 1.) An ACI item with the following protected item isn't rejected: "...attributeValue { must_be_a_name_value_pair }..."
> 2.) Incomplete ACIs like "{ identificationTag "id2" }" aren't rejected
> I add some commented test cases to ACIItemSyntaxCheckerTest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-891) ACIItemSyntaxChecker accepts
incomplete or invalid ACI Items
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRSERVER-891:
----------------------------------------
Fix Version/s: 1.5.2
May be we can postpone it to 1.5.2...
> ACIItemSyntaxChecker accepts incomplete or invalid ACI Items
> ------------------------------------------------------------
>
> Key: DIRSERVER-891
> URL: https://issues.apache.org/jira/browse/DIRSERVER-891
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.5.0
> Reporter: Stefan Seelmann
> Fix For: 1.5.2
>
>
> The ACIItemSyntaxChecker accepts incomplete or invalid ACI Items.
> 1.) An ACI item with the following protected item isn't rejected: "...attributeValue { must_be_a_name_value_pair }..."
> 2.) Incomplete ACIs like "{ identificationTag "id2" }" aren't rejected
> I add some commented test cases to ACIItemSyntaxCheckerTest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-891) ACIItemSyntaxChecker accepts
incomplete or invalid ACI Items
Posted by "Ersin Er (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486650 ]
Ersin Er commented on DIRSERVER-891:
------------------------------------
Checker grammar is optimized for checking only, yes. It eliminates some unnecessary object creations I think.
> ACIItemSyntaxChecker accepts incomplete or invalid ACI Items
> ------------------------------------------------------------
>
> Key: DIRSERVER-891
> URL: https://issues.apache.org/jira/browse/DIRSERVER-891
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.5.0
> Reporter: Stefan Seelmann
>
> The ACIItemSyntaxChecker accepts incomplete or invalid ACI Items.
> 1.) An ACI item with the following protected item isn't rejected: "...attributeValue { must_be_a_name_value_pair }..."
> 2.) Incomplete ACIs like "{ identificationTag "id2" }" aren't rejected
> I add some commented test cases to ACIItemSyntaxCheckerTest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRSERVER-891) ACIItemSyntaxChecker accepts
incomplete or invalid ACI Items
Posted by "Ersin Er (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ersin Er resolved DIRSERVER-891.
--------------------------------
Resolution: Fixed
Fixed here: http://svn.apache.org/viewvc?view=rev&revision=552349
> ACIItemSyntaxChecker accepts incomplete or invalid ACI Items
> ------------------------------------------------------------
>
> Key: DIRSERVER-891
> URL: https://issues.apache.org/jira/browse/DIRSERVER-891
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.5.0
> Reporter: Stefan Seelmann
> Assignee: Ersin Er
> Fix For: 1.5.1
>
>
> The ACIItemSyntaxChecker accepts incomplete or invalid ACI Items.
> 1.) An ACI item with the following protected item isn't rejected: "...attributeValue { must_be_a_name_value_pair }..."
> 2.) Incomplete ACIs like "{ identificationTag "id2" }" aren't rejected
> I add some commented test cases to ACIItemSyntaxCheckerTest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-891) ACIItemSyntaxChecker accepts
incomplete or invalid ACI Items
Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486099 ]
Stefan Seelmann commented on DIRSERVER-891:
-------------------------------------------
I also added the tests to ACIItemChekerTest and ACIItemParserTest. In ACIItemChekerTest they fail, in ACIItemParserTest they pass. So the parser and the checker behave different.
I saw that there are two grammars, ACIItem.g and ACIItemChecker.g. I assume the ACIItemChecker is optimized just to check whether the ACI is valid or not?
> ACIItemSyntaxChecker accepts incomplete or invalid ACI Items
> ------------------------------------------------------------
>
> Key: DIRSERVER-891
> URL: https://issues.apache.org/jira/browse/DIRSERVER-891
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.5.0
> Reporter: Stefan Seelmann
>
> The ACIItemSyntaxChecker accepts incomplete or invalid ACI Items.
> 1.) An ACI item with the following protected item isn't rejected: "...attributeValue { must_be_a_name_value_pair }..."
> 2.) Incomplete ACIs like "{ identificationTag "id2" }" aren't rejected
> I add some commented test cases to ACIItemSyntaxCheckerTest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-891) ACIItemSyntaxChecker accepts
incomplete or invalid ACI Items
Posted by "Ersin Er (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509439 ]
Ersin Er commented on DIRSERVER-891:
------------------------------------
OK I'll fix this ASAP. It seems I made the Checker lighter than required.
> ACIItemSyntaxChecker accepts incomplete or invalid ACI Items
> ------------------------------------------------------------
>
> Key: DIRSERVER-891
> URL: https://issues.apache.org/jira/browse/DIRSERVER-891
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.5.0
> Reporter: Stefan Seelmann
> Assignee: Ersin Er
> Fix For: 1.5.2
>
>
> The ACIItemSyntaxChecker accepts incomplete or invalid ACI Items.
> 1.) An ACI item with the following protected item isn't rejected: "...attributeValue { must_be_a_name_value_pair }..."
> 2.) Incomplete ACIs like "{ identificationTag "id2" }" aren't rejected
> I add some commented test cases to ACIItemSyntaxCheckerTest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRSERVER-891) ACIItemSyntaxChecker accepts
incomplete or invalid ACI Items
Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Seelmann closed DIRSERVER-891.
-------------------------------------
Uncommented one more test here: http://svn.apache.org/viewvc?view=rev&rev=567376
> ACIItemSyntaxChecker accepts incomplete or invalid ACI Items
> ------------------------------------------------------------
>
> Key: DIRSERVER-891
> URL: https://issues.apache.org/jira/browse/DIRSERVER-891
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.5.0
> Reporter: Stefan Seelmann
> Assignee: Ersin Er
> Fix For: 1.5.1
>
>
> The ACIItemSyntaxChecker accepts incomplete or invalid ACI Items.
> 1.) An ACI item with the following protected item isn't rejected: "...attributeValue { must_be_a_name_value_pair }..."
> 2.) Incomplete ACIs like "{ identificationTag "id2" }" aren't rejected
> I add some commented test cases to ACIItemSyntaxCheckerTest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DIRSERVER-891) ACIItemSyntaxChecker accepts
incomplete or invalid ACI Items
Posted by "Ersin Er (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ersin Er reassigned DIRSERVER-891:
----------------------------------
Assignee: Ersin Er
> ACIItemSyntaxChecker accepts incomplete or invalid ACI Items
> ------------------------------------------------------------
>
> Key: DIRSERVER-891
> URL: https://issues.apache.org/jira/browse/DIRSERVER-891
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.5.0
> Reporter: Stefan Seelmann
> Assignee: Ersin Er
> Fix For: 1.5.2
>
>
> The ACIItemSyntaxChecker accepts incomplete or invalid ACI Items.
> 1.) An ACI item with the following protected item isn't rejected: "...attributeValue { must_be_a_name_value_pair }..."
> 2.) Incomplete ACIs like "{ identificationTag "id2" }" aren't rejected
> I add some commented test cases to ACIItemSyntaxCheckerTest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-891) ACIItemSyntaxChecker accepts
incomplete or invalid ACI Items
Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Seelmann updated DIRSERVER-891:
--------------------------------------
Affects Version/s: 1.5.0
> ACIItemSyntaxChecker accepts incomplete or invalid ACI Items
> ------------------------------------------------------------
>
> Key: DIRSERVER-891
> URL: https://issues.apache.org/jira/browse/DIRSERVER-891
> Project: Directory ApacheDS
> Issue Type: Bug
> Affects Versions: 1.5.0
> Reporter: Stefan Seelmann
>
> The ACIItemSyntaxChecker accepts incomplete or invalid ACI Items.
> 1.) An ACI item with the following protected item isn't rejected: "...attributeValue { must_be_a_name_value_pair }..."
> 2.) Incomplete ACIs like "{ identificationTag "id2" }" aren't rejected
> I add some commented test cases to ACIItemSyntaxCheckerTest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.