[GitHub] rhtyd commented on a change in pull request #2605: xenserver: Add support for XS 7.3, 7.4 and XCP-ng 7.4

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #2605: xenserver: Add support for XS 7.3, 7.4 and XCP-ng 7.4
URL: https://github.com/apache/cloudstack/pull/2605#discussion_r184915803
 
 

 ##########
 File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##########
 @@ -2645,7 +2649,7 @@ private String actualIsoTemplate(final Connection conn) throws BadServerResponse
         final String[] items = xenVersion.split("\\.");
 
         // guest-tools.iso for XenServer version 7.0+
-        if (xenBrand.equals("XenServer") && Integer.parseInt(items[0]) >= 7) {
+        if ((xenBrand.equals("XenServer") || xenBrand.equals("XCP-ng")) && Integer.parseInt(items[0]) >= 7) {
 
 Review comment:
   Not sure how to address this, I'll let it be for this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services