You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wei Zhou <w....@leaseweb.com> on 2013/05/06 20:44:11 UTC
Review Request: (CLOUDSTACK-2319) fix "unable to add egress rules" in
SecurityGroup
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10957/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
This patch changes:
(1) CloudStack UI (egress rule in Security Group)
(2) findByUuidIncludingRemoved(uuid) return security_group_rule.id (find by security_group_rule.uuid) instead of security_group.id (find by security_group.uuid)
This addresses bug CLOUDSTACK-2319.
Diffs
-----
api/src/com/cloud/network/security/SecurityGroupRules.java d255e46
core/src/com/cloud/network/security/SecurityGroupRulesVO.java 82060ef
server/src/com/cloud/network/security/dao/SecurityGroupRulesDaoImpl.java f08ca05
ui/scripts/network.js 1bc4eba
Diff: https://reviews.apache.org/r/10957/diff/
Testing
-------
Testing ok.
Thanks,
Wei Zhou
Re: Review Request 10957: (CLOUDSTACK-2319) fix "unable to add egress rules"
in SecurityGroup
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10957/#review25825
-----------------------------------------------------------
Commit 62b09c9253a4a942f0e0b6649b87e18d4bc70464 in branch refs/heads/master from Wei Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=62b09c9 ]
CLOUDSTACK-2319: fix incorrect account_id in event table for Revoke SecurityGroupRule commands
(cherry picked from commit d9ba234d6c032aeb2ba04d4e6be0502de8a4efd9)
- ASF Subversion and Git Services
On May 6, 2013, 6:44 p.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10957/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 6:44 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-2319
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch changes:
> (1) CloudStack UI (egress rule in Security Group)
> (2) findByUuidIncludingRemoved(uuid) return security_group_rule.id (find by security_group_rule.uuid) instead of security_group.id (find by security_group.uuid)
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/security/SecurityGroupRules.java d255e46
> core/src/com/cloud/network/security/SecurityGroupRulesVO.java 82060ef
> server/src/com/cloud/network/security/dao/SecurityGroupRulesDaoImpl.java f08ca05
> ui/scripts/network.js 1bc4eba
>
> Diff: https://reviews.apache.org/r/10957/diff/
>
>
> Testing
> -------
>
> Testing ok.
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request 10957: (CLOUDSTACK-2319) fix "unable to add egress rules"
in SecurityGroup
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10957/#review25789
-----------------------------------------------------------
Commit d9ba234d6c032aeb2ba04d4e6be0502de8a4efd9 in branch refs/heads/4.2-forward from Wei Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d9ba234 ]
CLOUDSTACK-2319: fix incorrect account_id in event table for Revoke SecurityGroupRule commands
- ASF Subversion and Git Services
On May 6, 2013, 6:44 p.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10957/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 6:44 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-2319
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch changes:
> (1) CloudStack UI (egress rule in Security Group)
> (2) findByUuidIncludingRemoved(uuid) return security_group_rule.id (find by security_group_rule.uuid) instead of security_group.id (find by security_group.uuid)
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/security/SecurityGroupRules.java d255e46
> core/src/com/cloud/network/security/SecurityGroupRulesVO.java 82060ef
> server/src/com/cloud/network/security/dao/SecurityGroupRulesDaoImpl.java f08ca05
> ui/scripts/network.js 1bc4eba
>
> Diff: https://reviews.apache.org/r/10957/diff/
>
>
> Testing
> -------
>
> Testing ok.
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-2319) fix "unable to add egress rules" in
SecurityGroup
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10957/#review20216
-----------------------------------------------------------
Commit af5bf94b431cea91f424ec1b5dc038a22d25a954 in branch refs/heads/master from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=af5bf94 ]
CLOUDSTACK-2319: fix "unable to add egress rules" in SecurityGroup
Signed-off-by: Chip Childers <ch...@gmail.com>
- ASF Subversion and Git Services
On May 6, 2013, 6:44 p.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10957/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 6:44 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> This patch changes:
> (1) CloudStack UI (egress rule in Security Group)
> (2) findByUuidIncludingRemoved(uuid) return security_group_rule.id (find by security_group_rule.uuid) instead of security_group.id (find by security_group.uuid)
>
>
> This addresses bug CLOUDSTACK-2319.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/security/SecurityGroupRules.java d255e46
> core/src/com/cloud/network/security/SecurityGroupRulesVO.java 82060ef
> server/src/com/cloud/network/security/dao/SecurityGroupRulesDaoImpl.java f08ca05
> ui/scripts/network.js 1bc4eba
>
> Diff: https://reviews.apache.org/r/10957/diff/
>
>
> Testing
> -------
>
> Testing ok.
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request 10957: (CLOUDSTACK-2319) fix "unable to add egress rules"
in SecurityGroup
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10957/#review25828
-----------------------------------------------------------
Commit 15b03a2d246a6c19eed9f6c3e5bbf4a228800426 in branch refs/heads/4.1 from Wei Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=15b03a2 ]
CLOUDSTACK-2319: fix incorrect account_id in event table for Revoke SecurityGroupRule commands
(cherry picked from commit d9ba234d6c032aeb2ba04d4e6be0502de8a4efd9)
- ASF Subversion and Git Services
On May 6, 2013, 6:44 p.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10957/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 6:44 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-2319
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch changes:
> (1) CloudStack UI (egress rule in Security Group)
> (2) findByUuidIncludingRemoved(uuid) return security_group_rule.id (find by security_group_rule.uuid) instead of security_group.id (find by security_group.uuid)
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/security/SecurityGroupRules.java d255e46
> core/src/com/cloud/network/security/SecurityGroupRulesVO.java 82060ef
> server/src/com/cloud/network/security/dao/SecurityGroupRulesDaoImpl.java f08ca05
> ui/scripts/network.js 1bc4eba
>
> Diff: https://reviews.apache.org/r/10957/diff/
>
>
> Testing
> -------
>
> Testing ok.
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-2319) fix "unable to add egress rules" in
SecurityGroup
Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10957/#review20223
-----------------------------------------------------------
Ship it!
Ship It!
- Chip Childers
On May 6, 2013, 6:44 p.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10957/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 6:44 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> This patch changes:
> (1) CloudStack UI (egress rule in Security Group)
> (2) findByUuidIncludingRemoved(uuid) return security_group_rule.id (find by security_group_rule.uuid) instead of security_group.id (find by security_group.uuid)
>
>
> This addresses bug CLOUDSTACK-2319.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/security/SecurityGroupRules.java d255e46
> core/src/com/cloud/network/security/SecurityGroupRulesVO.java 82060ef
> server/src/com/cloud/network/security/dao/SecurityGroupRulesDaoImpl.java f08ca05
> ui/scripts/network.js 1bc4eba
>
> Diff: https://reviews.apache.org/r/10957/diff/
>
>
> Testing
> -------
>
> Testing ok.
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-2319) fix "unable to add egress rules" in
SecurityGroup
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10957/#review20214
-----------------------------------------------------------
Commit b02bbc841e0ca927b5e208c394dbc8631bb1c389 in branch refs/heads/4.1 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b02bbc8 ]
CLOUDSTACK-2319: fix "unable to add egress rules" in SecurityGroup
Signed-off-by: Chip Childers <ch...@gmail.com>
- ASF Subversion and Git Services
On May 6, 2013, 6:44 p.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10957/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 6:44 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> This patch changes:
> (1) CloudStack UI (egress rule in Security Group)
> (2) findByUuidIncludingRemoved(uuid) return security_group_rule.id (find by security_group_rule.uuid) instead of security_group.id (find by security_group.uuid)
>
>
> This addresses bug CLOUDSTACK-2319.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/security/SecurityGroupRules.java d255e46
> core/src/com/cloud/network/security/SecurityGroupRulesVO.java 82060ef
> server/src/com/cloud/network/security/dao/SecurityGroupRulesDaoImpl.java f08ca05
> ui/scripts/network.js 1bc4eba
>
> Diff: https://reviews.apache.org/r/10957/diff/
>
>
> Testing
> -------
>
> Testing ok.
>
>
> Thanks,
>
> Wei Zhou
>
>