You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/07/12 06:49:21 UTC
[GitHub] [zeppelin] rickchengx opened a new pull request #4171: [ZEPPELIN-5456] Allow users to set the config 'imagePullPolicy' under k8s mode
rickchengx opened a new pull request #4171:
URL: https://github.com/apache/zeppelin/pull/4171
### What is this PR for?
Currently, the interpreter pod created by `k8s/interpreter/100-interpreter-spec.yaml` cannot set the `imagePullPolicy` for both the zeppelin image and the spark image (When using the spark interpreter, the spark image needs to be set for the init container).
So this PR adds two properties:
* `zeppelin.k8s.interpreter.container.imagePullPolicy`, to set the pull policy of the zeppelin image.
* `zeppelin.k8s.spark.container.imagePullPolicy`, to set the pull policy of the spark image.
Users can set these two properties directly in the interpreter settings, such as:
```
%spark.conf
zeppelin.k8s.interpreter.container.imagePullPolicy Always
zeppelin.k8s.spark.container.imagePullPolicy Always
```
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* <https://issues.apache.org/jira/browse/ZEPPELIN-5456>
### How should this be tested?
* CI pass and manually tested
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] rickchengx commented on pull request #4171: [ZEPPELIN-5456] Allow users to set the config 'imagePullPolicy' under k8s mode
Posted by GitBox <gi...@apache.org>.
rickchengx commented on pull request #4171:
URL: https://github.com/apache/zeppelin/pull/4171#issuecomment-878745664
> I don't think we need to include all the configuration options in our example `100-interpreter-spec.yaml`. This file should be configured by the user.
> Maybe we should write more documentation on how to change the file to suit use cases.
Hi, @Reamer
Thanks for your comment. In order to support more k8s features, the `100-interpreter-spec.yaml` file may indeed become more complicated. But if users are required to modify `100-interpreter-spec.yaml`, it may lead to a poor user experience. Especially when the user directly runs the zeppelin server in the k8s cluster, every time the `100-interpreter-spec.yaml` file is modified, the docker image needs to be rebuilt and deployed.
Therefore, I think that common features should be placed in the `100-interpreter-spec.yaml` file as much as possible so that users can directly configure their desired properties in the interpreter settings. When users need to configure some more customized properties, they can modify the `100-interpreter-spec.yaml` file.
I think `imagePullpolicy` is a property that users may often need to configure. For example, when users update images with the same tag in the repository, they can set the `imagePullpolicy` to be `Always`. Or when users need to shorten the time of image pull, they can set the `imagePullpolicy` to be `IfNotPresent`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4171: [ZEPPELIN-5456] Allow users to set the config 'imagePullPolicy' under k8s mode
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4171:
URL: https://github.com/apache/zeppelin/pull/4171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] rickchengx commented on pull request #4171: [ZEPPELIN-5456] Allow users to set the config 'imagePullPolicy' under k8s mode
Posted by GitBox <gi...@apache.org>.
rickchengx commented on pull request #4171:
URL: https://github.com/apache/zeppelin/pull/4171#issuecomment-879553861
> I have merged #4170. Please rebase and add the documentation part.
Thanks, I have rebased and added the documentation part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4171: [ZEPPELIN-5456] Allow users to set the config 'imagePullPolicy' under k8s mode
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4171:
URL: https://github.com/apache/zeppelin/pull/4171#issuecomment-878790651
Please expand the documentation on this function so that new users know about it and how to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4171: [ZEPPELIN-5456] Allow users to set the config 'imagePullPolicy' under k8s mode
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4171:
URL: https://github.com/apache/zeppelin/pull/4171#issuecomment-878288842
I don't think we need to include all the configuration options in our example `100-interpreter-spec.yaml`. This file should be configured by the user.
Maybe we should write more documentation on how to change the file to suit use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4171: [ZEPPELIN-5456] Allow users to set the config 'imagePullPolicy' under k8s mode
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4171:
URL: https://github.com/apache/zeppelin/pull/4171#issuecomment-879138979
I have merged #4170. Please rebase and add the documentation part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org