You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/06 14:03:53 UTC
[GitHub] [pulsar] eolivelli opened a new pull request #8465: Update deps, allow to run tests with forkCount=1
eolivelli opened a new pull request #8465:
URL: https://github.com/apache/pulsar/pull/8465
# Motivation
In current master you cannot run the tests with "forkCount=1", this is very annoying as by default we are running all of the tests in parallel.
This change upgrades a few testing dependencies and fixes a problem with PowerMock + Testng + Log4j2 + forkCount=1
### Modifications
- Upgrade TestNG
- Upgrade PowerMock
- Upgrade Mockito
- Upgrade log4j2
- Upgrade javaassist
- Upgrade Maven Surefire plugin
### Verifying this change
All tests should pass
This change is a trivial rework / code cleanup without any test coverage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8465: Update deps, allow to run tests with forkCount=1
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8465:
URL: https://github.com/apache/pulsar/pull/8465#issuecomment-723799942
> this is a small clean up but it will help in understanding the dynamics of the test suite.
> I suspect we have a few leaks that slow down CI,
> I am running the test suite locally with forlCount=1 in order to seek for the causes
@eolivelli the changes LGTM.
btw. One way to get more visibility into the Maven build would be to use [Gradle Build Scans for Maven](https://scans.gradle.com/#maven) ([more details](https://docs.gradle.com/enterprise/maven-extension/#using_build_scans)) to get detailed reports of the build execution. Gradle has tools for Maven as well. It's part of Gradle Enterprise, but the Builds Scans can be used for free when using the public server. It's well suitable for opensource projects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8465: Update deps, allow to run tests with forkCount=1
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8465:
URL: https://github.com/apache/pulsar/pull/8465#issuecomment-723587779
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8465: Update deps, allow to run tests with forkCount=1
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8465:
URL: https://github.com/apache/pulsar/pull/8465#issuecomment-723579413
@lhotari this is a small clean up but it will help in understanding the dynamics of the test suite.
I suspect we have a few leaks that slow down CI,
I am running the test suite locally with forlCount=1 in order to seek for the causes
cc @jiazhai @sijie @codelipenghui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8465: Update deps, allow to run tests with forkCount=1
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8465:
URL: https://github.com/apache/pulsar/pull/8465#issuecomment-723476966
It looks like I have to update testing xml files according to
https://github.com/cbeust/testng/pull/2023/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8465: Update deps, allow to run tests with forkCount=1
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8465:
URL: https://github.com/apache/pulsar/pull/8465#issuecomment-723874535
thank you @jiazhai !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #8465: Update deps, allow to run tests with forkCount=1
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #8465:
URL: https://github.com/apache/pulsar/pull/8465#issuecomment-723577802
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai merged pull request #8465: Update deps, allow to run tests with forkCount=1
Posted by GitBox <gi...@apache.org>.
jiazhai merged pull request #8465:
URL: https://github.com/apache/pulsar/pull/8465
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org