You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2014/11/10 18:10:03 UTC

Review Request 27815: Select filter should handle options with different value and label

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27815/
-----------------------------------------------------------

Review request for Ambari and Andriy Babiichuk.


Bugs: AMBARI-8256
    https://issues.apache.org/jira/browse/AMBARI-8256


Repository: ambari


Description
-------

Select should be able to filter when value and label of filter options are different.


Diffs
-----

  ambari-web/app/views/common/filter_view.js 6e28209 
  ambari-web/app/views/common/table_view.js bbf346a 
  ambari-web/app/views/main/admin/stack_versions/stack_version_view.js 3ce30c2 
  ambari-web/app/views/main/alert_definitions_view.js 0b828c6 
  ambari-web/app/views/main/apps_view.js 1190210 
  ambari-web/app/views/main/dashboard/config_history_view.js 1f1d0b3 
  ambari-web/app/views/main/host/stack_versions_view.js cf6a06c 
  ambari-web/app/views/main/mirroring/datasets_view.js 9dd1720 
  ambari-web/app/views/main/mirroring/jobs_view.js c8973d1 

Diff: https://reviews.apache.org/r/27815/diff/


Testing
-------

  5023 tests complete (7 seconds)
  60 tests pending


Thanks,

Andrii Tkach


Re: Review Request 27815: Select filter should handle options with different value and label

Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27815/#review60620
-----------------------------------------------------------

Ship it!


Ship It!

- Andriy Babiichuk


On Ноя. 10, 2014, 5:10 п.п., Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27815/
> -----------------------------------------------------------
> 
> (Updated Ноя. 10, 2014, 5:10 п.п.)
> 
> 
> Review request for Ambari and Andriy Babiichuk.
> 
> 
> Bugs: AMBARI-8256
>     https://issues.apache.org/jira/browse/AMBARI-8256
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Select should be able to filter when value and label of filter options are different.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/views/common/filter_view.js 6e28209 
>   ambari-web/app/views/common/table_view.js bbf346a 
>   ambari-web/app/views/main/admin/stack_versions/stack_version_view.js 3ce30c2 
>   ambari-web/app/views/main/alert_definitions_view.js 0b828c6 
>   ambari-web/app/views/main/apps_view.js 1190210 
>   ambari-web/app/views/main/dashboard/config_history_view.js 1f1d0b3 
>   ambari-web/app/views/main/host/stack_versions_view.js cf6a06c 
>   ambari-web/app/views/main/mirroring/datasets_view.js 9dd1720 
>   ambari-web/app/views/main/mirroring/jobs_view.js c8973d1 
> 
> Diff: https://reviews.apache.org/r/27815/diff/
> 
> 
> Testing
> -------
> 
>   5023 tests complete (7 seconds)
>   60 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>