[GitHub] [spark] Kimahriman commented on a diff in pull request #36767: [SPARK-39363][K8S] Deprecate k8s memory overhead and make it optional

[GitBox <gi...@apache.org>]

Kimahriman commented on code in PR #36767:
URL: https://github.com/apache/spark/pull/36767#discussion_r889525973


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala:
##########
@@ -73,7 +69,7 @@ private[spark] class BasicDriverFeatureStep(conf: KubernetesDriverConf)
   private val memoryOverheadFactor = if (conf.contains(DRIVER_MEMORY_OVERHEAD_FACTOR)) {
     conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR)
   } else {
-    defaultOverheadFactor
+    defaultOverheadFactor.getOrElse(conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR))

Review Comment:
   Let me know if this logic makes sense for get the new config if defined, otherwise deprecated config if defined, otherwise default value of new config



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org