You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by trancee <gi...@git.apache.org> on 2015/08/07 05:02:53 UTC
[GitHub] cordova-plugin-splashscreen pull request: Implementing FadeSplashS...
GitHub user trancee opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/53
Implementing FadeSplashScreen for Android
FadeSplashScreen is supported by using AlphaAnimation to fade out the ImageView.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trancee/cordova-plugin-splashscreen android-FadeSplashScreen
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/53.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #53
----
commit 56fab8b2f130ecf231d95ff5fb0a7a3e0b74a7dd
Author: Philipp Grosswiler <ph...@ruma.co.id>
Date: 2015-08-06T09:29:41Z
Added support for FadeSplashScreen.
commit 386f0d9b74083fdf4464791d48a5af638b78572e
Author: Philipp Grosswiler <ph...@ruma.co.id>
Date: 2015-08-07T02:23:11Z
Added DecelerateInterpolator for smoother fading experience.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9538 - Implementing F...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-166959203
@trancee, could you please update this to be consistent with the current documented format [`FadeSplashScreenDuration (float, defaults to 3000)`](https://github.com/apache/cordova-plugin-splashscreen#ios-quirks) on iOS?
A fallback can be also added to handle seconds-values for backwards-compatibility:
https://github.com/apache/cordova-plugin-splashscreen/blob/ccb3c2f4533fa52da474c33a7adc5ab5a887a805/src/ios/CDVSplashScreen.m#L346-L351
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Implementing FadeSplashS...
Posted by idpaterson <gi...@git.apache.org>.
Github user idpaterson commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-132706052
Thanks, this works well! Can you follow through with the [recommended contributor workflow](http://cordova.apache.org/#contribute) then update this pull request to match the corresponding issue that you create in [Jira](https://issues.apache.org/jira/) to make sure this fix is seen by the correct people?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Implementing FadeSplashS...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-130359281
Other time values are given in msecs. You should be consistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Implementing FadeSplashS...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-130511210
SplashScreenDelay (number, default to 10000). Amount of time in milliseconds to wait before automatically hide splash screen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Implementing FadeSplashS...
Posted by trancee <gi...@git.apache.org>.
Github user trancee commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-130476012
I am just being compatible to the already existing preference which is given in seconds (coming from iOS).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9538 - Implementing F...
Posted by trancee <gi...@git.apache.org>.
Github user trancee closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/53
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Implementing FadeSplashS...
Posted by trancee <gi...@git.apache.org>.
Github user trancee commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-130521975
I agree with your point, but due to the already implemented FadeSplashScreenDuration (splash-screen Fade duration in seconds) I can not simply change the documented behavior. It would be incompatible with the iOS platform.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9538 - Implementing F...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-168023487
@trancee, I've updated this PR in #73 - please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9538 - Implementing F...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-170498911
@trancee, could you please close this?
#73 has been merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9538 - Implementing F...
Posted by trancee <gi...@git.apache.org>.
Github user trancee commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-170499604
Sure. Thanks for the merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Implementing FadeSplashS...
Posted by spiritax <gi...@git.apache.org>.
Github user spiritax commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-128665519
Thanks for the code.
The property FadeSplashScreenDuration (float, defaults to 2): is a float, so you should probably read a Double then cast it on Integer.
final int splashscreenDuration = (int)(preferences.getDouble("FadeSplashScreenDuration", 2) * 1000);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org