Re: [PR] [Fix-17406]Fix Parameter passing feature is unavailable in SQL Task [dolphinscheduler]

["ruanwenjun (via GitHub)" <gi...@apache.org>]

ruanwenjun commented on PR #17456:
URL: https://github.com/apache/dolphinscheduler/pull/17456#issuecomment-3252673510

   > > Please fix this in `SqlTask`
   > > ```
   > > taskExecutionContext.setVarPool(sqlParameters.getVarPool());
   > > ```
   > > 
   > > 
   > >     
   > >       
   > >     
   > > 
   > >       
   > >     
   > > 
   > >     
   > >   
   > > Rather than create a common method.
   > > Before adding the common varpool handling, it is best to modify the task plugin's return result to explicitly return the varpool. Otherwise, we are essentially repeatedly modifying a variable, which is prone to causing problems.
   > 
   > Is it about adding varPool replacement in each task (such as `SqlTask`), rather than handling it uniformly in `PhysicalTaskExecutor`?
   
   Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org