[GitHub] wes3 commented on a change in pull request #637: LoRa Datarate changes

[GitBox <gi...@apache.org>]

wes3 commented on a change in pull request #637: LoRa Datarate changes
URL: https://github.com/apache/mynewt-core/pull/637#discussion_r147288991
 
 

 ##########
 File path: apps/lora_app_shell/src/las_cmd.c
 ##########
 @@ -743,27 +742,21 @@ las_cmd_app_port(int argc, char **argv)
             console_printf("Failed to close app port %u err=%d\n", port, rc);
         }
     } else if (!strcmp(argv[1], "cfg")) {
-        if (argc != 5) {
+        if (argc != 4) {
             console_printf("Invalid # of arguments.\n");
             goto cmd_app_port_err;
         }
-        dr = parse_ull_bounds(argv[2], 0, LORAMAC_TX_MAX_DATARATE, &rc);
-        if (rc) {
-            console_printf("Invalid data rate. Must be between 0 and "
-                           "%d (inclusve)\n", LORAMAC_TX_MAX_DATARATE);
-            return 0;
-        }
         retries = parse_ull_bounds(argv[2], 1, MAX_ACK_RETRIES, &rc);
 
 Review comment:
   Yes indeed. Good catch. I will fix it directly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services