[GitHub] [lucene] mikemccand commented on a diff in pull request #1016: LUCENE-10646: Add some comment on LevenshteinAutomata

[GitBox <gi...@apache.org>]

mikemccand commented on code in PR #1016:
URL: https://github.com/apache/lucene/pull/1016#discussion_r933148269


##########
lucene/core/src/java/org/apache/lucene/util/automaton/Automaton.java:
##########
@@ -589,8 +589,15 @@ public String toDot() {
     }
 
     Transition t = new Transition();
-
-    for (int state = 0; state < numStates; state++) {
+    Queue<Integer> queue = new ArrayDeque<>();
+    Set<Integer> meet = new HashSet<>();
+    queue.add(0);
+    while (!queue.isEmpty()) {

Review Comment:
   Could we use `== false` instead of `!`, for better verbosity to reduce the risk of accidental future bugs on refactoring?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org