[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1142: DISPATCH-2046: Removed the connector lock and used the server lock

[GitBox <gi...@apache.org>]

ganeshmurthy commented on a change in pull request #1142:
URL: https://github.com/apache/qpid-dispatch/pull/1142#discussion_r621440564



##########
File path: src/server.c
##########
@@ -1372,6 +1391,7 @@ void qd_server_free(qd_server_t *qd_server)
     if (!qd_server) return;
 
     qd_http_server_free(qd_server->http);
+    qd_timer_visit(true);

Review comment:
       Take this scenario where a client closes its connection, the qd_connection_free() is called which schedules a timer here - https://github.com/apache/qpid-dispatch/blob/main/src/server.c#L917
   This newly scheduled timer is set to go off in ctx->connector->delay seconds (maybe 5 seconds or so). This timer gets added to the scheduled_timers in timer.c. The router shuts down before the timer can fire. We need to step thru the scheduled_timers and take care of all the timers which is what I am trying to do here. Once the timers are scheduled, how can the owner access the timer? I am sorry if that is something rudimentary I missed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org