[GitHub] spark pull request #19077: [SPARK-21860][core]Improve memory reuse for heap ...

[jerryshao <gi...@git.apache.org>]

Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19077#discussion_r143380706
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ---
    @@ -116,9 +116,10 @@ private [sql] object GenArrayData {
            s"final ArrayData $arrayDataName = new $genericArrayClass($arrayName);",
            arrayDataName)
         } else {
    +      val numBytes = elementType.defaultSize * numElements
           val unsafeArraySizeInBytes =
             UnsafeArrayData.calculateHeaderPortionInBytes(numElements) +
    -        ByteArrayMethods.roundNumberOfBytesToNearestWord(elementType.defaultSize * numElements)
    +        ByteArrayMethods.roundNumberOfBytesToNearestWord(numBytes).toInt
    --- End diff --
    
    Minor: why don't we inline this instead of creating a new variable?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org