You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/14 09:09:26 UTC
[GitHub] [incubator-pekko] jrudolph opened a new pull request, #44: stream: fix regression in JsonFraming
jrudolph opened a new pull request, #44:
URL: https://github.com/apache/incubator-pekko/pull/44
Was introduced in 6b30134c5c7e8deefdfc7ff9a3e74e0bbd2d433b where an invariant was changed what `pos` can be when the loop is run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning merged pull request #44: stream: fix regression in JsonFraming
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #44: stream: fix regression in JsonFraming
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#issuecomment-1567078277
@pjfanning Let's see if we can get this in 1.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #44: stream: fix regression in JsonFraming
Posted by GitBox <gi...@apache.org>.
He-Pin commented on PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#issuecomment-1314093497
Thanks, origin reported in https://github.com/akka/akka/issues/31569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #44: stream: fix regression in JsonFraming
Posted by GitBox <gi...@apache.org>.
He-Pin commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#discussion_r1025379868
##########
akka-stream/src/main/scala/akka/stream/impl/JsonObjectParser.scala:
##########
@@ -107,21 +107,22 @@ import akka.util.ByteString
val bufSize = buffer.length
skipToNextObject(bufSize)
+ val maxObjectLengthIndex = if (maximumObjectLength == Int.MaxValue) Int.MaxValue else pos + maximumObjectLength
Review Comment:
What if maximumObjectLength is something like `Int.MaxValue - 1`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #44: stream: fix regression in JsonFraming
Posted by GitBox <gi...@apache.org>.
He-Pin commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#discussion_r1025379868
##########
akka-stream/src/main/scala/akka/stream/impl/JsonObjectParser.scala:
##########
@@ -107,21 +107,22 @@ import akka.util.ByteString
val bufSize = buffer.length
skipToNextObject(bufSize)
+ val maxObjectLengthIndex = if (maximumObjectLength == Int.MaxValue) Int.MaxValue else pos + maximumObjectLength
Review Comment:
What if maximumObjectLength is something like `Int.MaxValue - 1`?
If I change the last test case to `JsonFraming.objectScanner(Int.MaxValue - 1)`, then it will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jrudolph commented on a diff in pull request #44: stream: fix regression in JsonFraming
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#discussion_r1087680362
##########
stream/src/main/scala/org/apache/pekko/stream/impl/JsonObjectParser.scala:
##########
@@ -117,21 +117,22 @@ import pekko.util.ByteString
val bufSize = buffer.length
skipToNextObject(bufSize)
+ val maxObjectLengthIndex = if (pos + maximumObjectLength < 0) Int.MaxValue else pos + maximumObjectLength
Review Comment:
@He-Pin what do you think about this solution? This way we catch the overflow directly. On the other hand, such a big `maximumObjectLength` is unlikely to work anyway because we cannot accommodate such a big object including any padding into our buffer... (i.e. we'll still fail in `offer`). Supporting huge objects is not economical in any case right now because of the buffer management issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #44: stream: fix regression in JsonFraming
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#discussion_r1209393862
##########
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/JsonFramingSpec.scala:
##########
@@ -41,7 +41,7 @@ class JsonFramingSpec extends PekkoSpec {
|""".stripMargin // also should complete once notices end of array
val result =
- Source.single(ByteString(input)).via(JsonFraming.objectScanner(Int.MaxValue)).runFold(Seq.empty[String]) {
+ Source.single(ByteString(input)).via(JsonFraming.objectScanner(64)).runFold(Seq.empty[String]) {
Review Comment:
I changed it `54`, the test case not pass.
```
JSON element exceeded maximumObjectLength (54 bytes)!
org.apache.pekko.stream.scaladsl.Framing$FramingException: JSON element exceeded maximumObjectLength (54 bytes)!
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #44: stream: fix regression in JsonFraming
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#issuecomment-1567276745
merged - it's not too late to object, we can always add extra changes or revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #44: stream: fix regression in JsonFraming
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#issuecomment-1566082358
https://github.com/apache/incubator-pekko/commit/6b30134c5c7e8deefdfc7ff9a3e74e0bbd2d433b is a pre-Pekko commit
https://github.com/akka/akka/commit/6b30134c5c7e8deefdfc7ff9a3e74e0bbd2d433b is the akka link and it shows that this code is part of akka 2.6.20 and since pekko 1.0.0 is meant to be a close approximation of akka 2.6.20, you could say that this is not a blocker for 1.0.0
I'm open to having something done about this in 1.0.0 but we sort of need a quick decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #44: stream: fix regression in JsonFraming
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#issuecomment-1566076752
I would also suggest that if we cannot get this fix out by release, lets revert the JSON framing change that caused the regression. Better to release something that is slightly slower rather than something that is broken
@pjfanning @jrudolph @raboof @He-Pin @Claudenw wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #44: stream: fix regression in JsonFraming
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#issuecomment-1566084039
I've added it back to milestone while this issue is further discussed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #44: stream: fix regression in JsonFraming
Posted by GitBox <gi...@apache.org>.
He-Pin commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#discussion_r1025379868
##########
akka-stream/src/main/scala/akka/stream/impl/JsonObjectParser.scala:
##########
@@ -107,21 +107,22 @@ import akka.util.ByteString
val bufSize = buffer.length
skipToNextObject(bufSize)
+ val maxObjectLengthIndex = if (maximumObjectLength == Int.MaxValue) Int.MaxValue else pos + maximumObjectLength
Review Comment:
What if maximumObjectLength is `Int.MaxValue - 1`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #44: stream: fix regression in JsonFraming
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#issuecomment-1332390340
@jrudolph You need to rebase this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #44: stream: fix regression in JsonFraming
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#issuecomment-1566071610
> Dropped from 1.0.0 milestone as it is incomplete and having it in the milestone makes it look like a blocker.
This might be a bit rash, basically without this change json framing is broken. Should try and get this out by release but the questions raised need to be resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #44: stream: fix regression in JsonFraming
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#issuecomment-1567233357
Close and reopen for retrigger the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jrudolph commented on a diff in pull request #44: stream: fix regression in JsonFraming
Posted by GitBox <gi...@apache.org>.
jrudolph commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#discussion_r1026208607
##########
akka-stream/src/main/scala/akka/stream/impl/JsonObjectParser.scala:
##########
@@ -107,21 +107,22 @@ import akka.util.ByteString
val bufSize = buffer.length
skipToNextObject(bufSize)
+ val maxObjectLengthIndex = if (maximumObjectLength == Int.MaxValue) Int.MaxValue else pos + maximumObjectLength
Review Comment:
Good point. I wonder if the code can made to work in those cases, where leading bytes to be skipped plus object will not fit into an array?
We should definitely fix the condition here but might also want to add a guard to `offer` to avoid creating a new array with negative size and also throw the FramingException from below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Claudenw commented on a diff in pull request #44: stream: fix regression in JsonFraming
Posted by "Claudenw (via GitHub)" <gi...@apache.org>.
Claudenw commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#discussion_r1201906618
##########
stream/src/main/scala/org/apache/pekko/stream/impl/JsonObjectParser.scala:
##########
@@ -117,21 +117,22 @@ import pekko.util.ByteString
val bufSize = buffer.length
skipToNextObject(bufSize)
+ val maxObjectLengthIndex = if (pos + maximumObjectLength < 0) Int.MaxValue else pos + maximumObjectLength
Review Comment:
Do you have a check for "huge objects"? Perhaps placing an upper limit on the object size is a good start until a complete solution can be discovered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin closed pull request #44: stream: fix regression in JsonFraming
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin closed pull request #44: stream: fix regression in JsonFraming
URL: https://github.com/apache/incubator-pekko/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #44: stream: fix regression in JsonFraming
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#issuecomment-1566070590
Dropped from 1.0.0 milestone as it is incomplete and having it in the milestone makes it look like a blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #44: stream: fix regression in JsonFraming
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#issuecomment-1566084569
> I would also suggest that if we cannot get this fix out by release, lets revert the JSON framing change that caused the regression. Better to release something that is slightly slower rather than something that is broken
>
> @pjfanning @jrudolph @raboof @He-Pin @Claudenw wdyt?
I would be happy with reverting https://github.com/apache/incubator-pekko/commit/6b30134c5c7e8deefdfc7ff9a3e74e0bbd2d433b
A fuller fix would be appreciated but I'd like to do whatever it takes to get the 1.0.0 release train moving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #44: stream: fix regression in JsonFraming
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#issuecomment-1567239750
@mdedetrich @jrudolph I checked this code locally and can confirm the current fix is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #44: stream: fix regression in JsonFraming
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#issuecomment-1566084815
> https://github.com/akka/akka/commit/6b30134c5c7e8deefdfc7ff9a3e74e0bbd2d433b is the akka link and it shows that this code is part of akka 2.6.20 and since pekko 1.0.0 is meant to be a close approximation of akka 2.6.20, you could say that this is not a blocker for 1.0.0
Right but this is an exceptional circumstance, Akka basically broke the JSON framing right before the license change happened and then fixed it after the license change. I understand that we want Pekko 1.0.x to be like Akka 2.6.0 but we have done exceptions, and one of those exceptions is with critical bugs (and I would classify this as critical since it doesn't work, and it did work ~2 months(iirc) in a previous version of Akka before the license change.
> I'm open to having something done about this in 1.0.0 but we sort of need a quick decision.
> I would be happy with reverting https://github.com/apache/incubator-pekko/commit/6b30134c5c7e8deefdfc7ff9a3e74e0bbd2d433b
Likewise, I would also suggest if this is not resolved by the time of one of the final release candidates then lets just revert the commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #44: stream: fix regression in JsonFraming
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#issuecomment-1566085873
we could do this a 2 phase
1. revert https://github.com/apache/incubator-pekko/commit/6b30134c5c7e8deefdfc7ff9a3e74e0bbd2d433b
2. follow up with better fix
1 is for v1.0.0 release and 2 is a maybe for 1.0.0 release but we won't wait for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #44: stream: fix regression in JsonFraming
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#issuecomment-1566086161
Okay, lets wait a few days to see if anyone responds and if this fix isn't landed/finished by then lets make a revert commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org