[jira] [Commented] (AIRFLOW-5439) Schedule_interval is not recognized if specified in Default_args

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16925181#comment-16925181 ] 

ASF GitHub Bot commented on AIRFLOW-5439:
-----------------------------------------

InigoSJ commented on pull request #6058: [AIRFLOW-5439] Add 'schedule_interval' to 'default_args'
URL: https://github.com/apache/airflow/pull/6058
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
   
   - My PR addresses [AIRFLOW-5439] (https://issues.apache.org/jira/browse/AIRFLOW-5439)
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   When specifying the "schedule_interval" inside the "default_args", it is not recognized. 
   
   Adding a simple check to the dictionary would solve this. Note that this would overwrite the value if specified both inside "default_args" and outside ( I followed the convection as in [1]). In case this is not the preferred way, it's easy to change it to NOT overwrite.
   
   [1] https://github.com/apache/airflow/blob/master/airflow/models/dag.py#L232
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   No tests were checked since no major change was made. All test should pass since the 'schedule_interval' would be the same everywhere unless it's added to the dictionary.
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   No documentation needed
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Schedule_interval is not recognized if specified in Default_args
> ----------------------------------------------------------------
>
>                 Key: AIRFLOW-5439
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5439
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: DAG
>    Affects Versions: 1.9.0, 1.10.0, 1.10.1, 1.10.2, 1.10.3, 1.10.4, 1.10.5
>            Reporter: Inigo San Jose Visiers
>            Priority: Minor
>
> When specifying the "_schedule_interval_" inside the "_default_args_", it is not recognized. 
> This can lead to confusion when creating a DAG. 
> I have run into this confusion myself, as well as colleagues and some other users:
> https://stackoverflow.com/questions/57752214



--
This message was sent by Atlassian Jira
(v8.3.2#803003)