You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2016/01/24 22:49:10 UTC

lucene-solr git commit: revert this est change until we can fix geo API border cases (LUCENE-6956)

Repository: lucene-solr
Updated Branches:
  refs/heads/master 9d35aafc5 -> b62c6715d


revert this est change until we can fix geo API border cases (LUCENE-6956)


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/b62c6715
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/b62c6715
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/b62c6715

Branch: refs/heads/master
Commit: b62c6715df12616785732cc1011e11fe4faa16ca
Parents: 9d35aaf
Author: Michael McCandless <ma...@mikemccandless.com>
Authored: Sun Jan 24 16:48:51 2016 -0500
Committer: Mike McCandless <mi...@apache.org>
Committed: Sun Jan 24 16:48:51 2016 -0500

----------------------------------------------------------------------
 .../src/test/org/apache/lucene/util/BaseGeoPointTestCase.java  | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/b62c6715/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.java
----------------------------------------------------------------------
diff --git a/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.java b/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.java
index f84d696..4236e88 100644
--- a/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.java
+++ b/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.java
@@ -434,7 +434,8 @@ public abstract class BaseGeoPointTestCase extends LuceneTestCase {
     } else {
       result = -90 + 180.0 * random().nextDouble();
     }
-    return result;
+    // TODO: we should not do this here!  it weakens the test, and users don't pre-quantize the lat/lons they send us:
+    return unscaleLat(scaleLat(result));
   }
 
   public double randomLon(boolean small) {
@@ -444,7 +445,8 @@ public abstract class BaseGeoPointTestCase extends LuceneTestCase {
     } else {
       result = -180 + 360.0 * random().nextDouble();
     }
-    return result;
+    // TODO: we should not do this here!  it weakens the test, and users don't pre-quantize the lat/lons they send us:
+    return unscaleLon(scaleLon(result));
   }
 
   protected GeoRect randomRect(boolean small, boolean canCrossDateLine) {


Re: lucene-solr git commit: revert this est change until we can fix geo API border cases (LUCENE-6956)

Posted by Michael McCandless <lu...@mikemccandless.com>.
OK I figured it out ... I had long ago set GIT_AUTHOR_NAME/EMAIL as
env vars ... I think I have it working now, but let's see what I push
next!!

Thanks Uwe, git policeman :)

Mike McCandless

http://blog.mikemccandless.com

On Sun, Jan 24, 2016 at 5:00 PM, Uwe Schindler <uw...@thetaphi.de> wrote:
> I have it only for the single working copies, so my commits at Github or Forbiddenapis have different names. This is in the .git directory of my working copy (config) file:
>
> [core]
>         repositoryformatversion = 0
>         filemode = false
>         bare = false
>         logallrefupdates = true
>         symlinks = false
>         ignorecase = true
>         hideDotFiles = dotGitOnly
> [remote "origin"]
>         url = https://git-wip-us.apache.org/repos/asf/lucene-solr.git
>         fetch = +refs/heads/*:refs/remotes/origin/*
> [branch "master"]
>         remote = origin
>         merge = refs/heads/master
> [user]
>         email = uschindler@apache.org
>
> -----
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
> http://www.thetaphi.de
> eMail: uwe@thetaphi.de
>
>
>> -----Original Message-----
>> From: Michael McCandless [mailto:lucene@mikemccandless.com]
>> Sent: Sunday, January 24, 2016 10:57 PM
>> To: Lucene/Solr dev <de...@lucene.apache.org>
>> Subject: Re: lucene-solr git commit: revert this est change until we can fix geo
>> API border cases (LUCENE-6956)
>>
>> Argh!!!
>>
>> My ~/.gitconfig has:
>>
>> [user]
>>   email = mikemccand@apache.org
>>   name = Mike McCandless
>>
>> Which I think the "git config --global user.name ..." did ...
>>
>> I'll try to figure why my commits are the wrong username.
>>
>> Mike McCandless
>>
>> http://blog.mikemccandless.com
>>
>>
>> On Sun, Jan 24, 2016 at 4:52 PM, Uwe Schindler <uw...@thetaphi.de> wrote:
>> > Hi,
>> >
>> > you have still the wrong mail address for the GIT commit itsself:
>> >> Author: Michael McCandless <ma...@mikemccandless.com>
>> >> Authored: Sun Jan 24 16:48:51 2016 -0500
>> >
>> > The person who pushed is different:
>> >> Committer: Mike McCandless <mi...@apache.org>
>> >> Committed: Sun Jan 24 16:48:51 2016 -0500
>> >
>> > Uwe
>> >
>> > -----
>> > Uwe Schindler
>> > H.-H.-Meier-Allee 63, D-28213 Bremen
>> > http://www.thetaphi.de
>> > eMail: uwe@thetaphi.de
>> >
>> >
>> >> -----Original Message-----
>> >> From: mikemccand@apache.org [mailto:mikemccand@apache.org]
>> >> Sent: Sunday, January 24, 2016 10:49 PM
>> >> To: commits@lucene.apache.org
>> >> Subject: lucene-solr git commit: revert this est change until we can fix geo
>> >> API border cases (LUCENE-6956)
>> >>
>> >> Repository: lucene-solr
>> >> Updated Branches:
>> >>   refs/heads/master 9d35aafc5 -> b62c6715d
>> >>
>> >>
>> >> revert this est change until we can fix geo API border cases (LUCENE-6956)
>> >>
>> >>
>> >> Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
>> >> Commit: http://git-wip-us.apache.org/repos/asf/lucene-
>> >> solr/commit/b62c6715
>> >> Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/b62c6715
>> >> Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/b62c6715
>> >>
>> >> Branch: refs/heads/master
>> >> Commit: b62c6715df12616785732cc1011e11fe4faa16ca
>> >> Parents: 9d35aaf
>> >> Author: Michael McCandless <ma...@mikemccandless.com>
>> >> Authored: Sun Jan 24 16:48:51 2016 -0500
>> >> Committer: Mike McCandless <mi...@apache.org>
>> >> Committed: Sun Jan 24 16:48:51 2016 -0500
>> >>
>> >> ----------------------------------------------------------------------
>> >>  .../src/test/org/apache/lucene/util/BaseGeoPointTestCase.java  | 6
>> ++++--
>> >>  1 file changed, 4 insertions(+), 2 deletions(-)
>> >> ----------------------------------------------------------------------
>> >>
>> >>
>> >> http://git-wip-us.apache.org/repos/asf/lucene-
>> >>
>> solr/blob/b62c6715/lucene/sandbox/src/test/org/apache/lucene/util/BaseG
>> >> eoPointTestCase.java
>> >> ----------------------------------------------------------------------
>> >> diff --git
>> >>
>> a/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.j
>> >> ava
>> >>
>> b/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.j
>> >> ava
>> >> index f84d696..4236e88 100644
>> >> ---
>> >>
>> a/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.j
>> >> ava
>> >> +++
>> >>
>> b/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.j
>> >> ava
>> >> @@ -434,7 +434,8 @@ public abstract class BaseGeoPointTestCase
>> extends
>> >> LuceneTestCase {
>> >>      } else {
>> >>        result = -90 + 180.0 * random().nextDouble();
>> >>      }
>> >> -    return result;
>> >> +    // TODO: we should not do this here!  it weakens the test, and users
>> don't
>> >> pre-quantize the lat/lons they send us:
>> >> +    return unscaleLat(scaleLat(result));
>> >>    }
>> >>
>> >>    public double randomLon(boolean small) {
>> >> @@ -444,7 +445,8 @@ public abstract class BaseGeoPointTestCase
>> extends
>> >> LuceneTestCase {
>> >>      } else {
>> >>        result = -180 + 360.0 * random().nextDouble();
>> >>      }
>> >> -    return result;
>> >> +    // TODO: we should not do this here!  it weakens the test, and users
>> don't
>> >> pre-quantize the lat/lons they send us:
>> >> +    return unscaleLon(scaleLon(result));
>> >>    }
>> >>
>> >>    protected GeoRect randomRect(boolean small, boolean
>> canCrossDateLine)
>> >> {
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> > For additional commands, e-mail: dev-help@lucene.apache.org
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


RE: lucene-solr git commit: revert this est change until we can fix geo API border cases (LUCENE-6956)

Posted by Uwe Schindler <uw...@thetaphi.de>.
I have it only for the single working copies, so my commits at Github or Forbiddenapis have different names. This is in the .git directory of my working copy (config) file:

[core]
	repositoryformatversion = 0
	filemode = false
	bare = false
	logallrefupdates = true
	symlinks = false
	ignorecase = true
	hideDotFiles = dotGitOnly
[remote "origin"]
	url = https://git-wip-us.apache.org/repos/asf/lucene-solr.git
	fetch = +refs/heads/*:refs/remotes/origin/*
[branch "master"]
	remote = origin
	merge = refs/heads/master
[user]
	email = uschindler@apache.org

-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de


> -----Original Message-----
> From: Michael McCandless [mailto:lucene@mikemccandless.com]
> Sent: Sunday, January 24, 2016 10:57 PM
> To: Lucene/Solr dev <de...@lucene.apache.org>
> Subject: Re: lucene-solr git commit: revert this est change until we can fix geo
> API border cases (LUCENE-6956)
> 
> Argh!!!
> 
> My ~/.gitconfig has:
> 
> [user]
>   email = mikemccand@apache.org
>   name = Mike McCandless
> 
> Which I think the "git config --global user.name ..." did ...
> 
> I'll try to figure why my commits are the wrong username.
> 
> Mike McCandless
> 
> http://blog.mikemccandless.com
> 
> 
> On Sun, Jan 24, 2016 at 4:52 PM, Uwe Schindler <uw...@thetaphi.de> wrote:
> > Hi,
> >
> > you have still the wrong mail address for the GIT commit itsself:
> >> Author: Michael McCandless <ma...@mikemccandless.com>
> >> Authored: Sun Jan 24 16:48:51 2016 -0500
> >
> > The person who pushed is different:
> >> Committer: Mike McCandless <mi...@apache.org>
> >> Committed: Sun Jan 24 16:48:51 2016 -0500
> >
> > Uwe
> >
> > -----
> > Uwe Schindler
> > H.-H.-Meier-Allee 63, D-28213 Bremen
> > http://www.thetaphi.de
> > eMail: uwe@thetaphi.de
> >
> >
> >> -----Original Message-----
> >> From: mikemccand@apache.org [mailto:mikemccand@apache.org]
> >> Sent: Sunday, January 24, 2016 10:49 PM
> >> To: commits@lucene.apache.org
> >> Subject: lucene-solr git commit: revert this est change until we can fix geo
> >> API border cases (LUCENE-6956)
> >>
> >> Repository: lucene-solr
> >> Updated Branches:
> >>   refs/heads/master 9d35aafc5 -> b62c6715d
> >>
> >>
> >> revert this est change until we can fix geo API border cases (LUCENE-6956)
> >>
> >>
> >> Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
> >> Commit: http://git-wip-us.apache.org/repos/asf/lucene-
> >> solr/commit/b62c6715
> >> Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/b62c6715
> >> Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/b62c6715
> >>
> >> Branch: refs/heads/master
> >> Commit: b62c6715df12616785732cc1011e11fe4faa16ca
> >> Parents: 9d35aaf
> >> Author: Michael McCandless <ma...@mikemccandless.com>
> >> Authored: Sun Jan 24 16:48:51 2016 -0500
> >> Committer: Mike McCandless <mi...@apache.org>
> >> Committed: Sun Jan 24 16:48:51 2016 -0500
> >>
> >> ----------------------------------------------------------------------
> >>  .../src/test/org/apache/lucene/util/BaseGeoPointTestCase.java  | 6
> ++++--
> >>  1 file changed, 4 insertions(+), 2 deletions(-)
> >> ----------------------------------------------------------------------
> >>
> >>
> >> http://git-wip-us.apache.org/repos/asf/lucene-
> >>
> solr/blob/b62c6715/lucene/sandbox/src/test/org/apache/lucene/util/BaseG
> >> eoPointTestCase.java
> >> ----------------------------------------------------------------------
> >> diff --git
> >>
> a/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.j
> >> ava
> >>
> b/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.j
> >> ava
> >> index f84d696..4236e88 100644
> >> ---
> >>
> a/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.j
> >> ava
> >> +++
> >>
> b/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.j
> >> ava
> >> @@ -434,7 +434,8 @@ public abstract class BaseGeoPointTestCase
> extends
> >> LuceneTestCase {
> >>      } else {
> >>        result = -90 + 180.0 * random().nextDouble();
> >>      }
> >> -    return result;
> >> +    // TODO: we should not do this here!  it weakens the test, and users
> don't
> >> pre-quantize the lat/lons they send us:
> >> +    return unscaleLat(scaleLat(result));
> >>    }
> >>
> >>    public double randomLon(boolean small) {
> >> @@ -444,7 +445,8 @@ public abstract class BaseGeoPointTestCase
> extends
> >> LuceneTestCase {
> >>      } else {
> >>        result = -180 + 360.0 * random().nextDouble();
> >>      }
> >> -    return result;
> >> +    // TODO: we should not do this here!  it weakens the test, and users
> don't
> >> pre-quantize the lat/lons they send us:
> >> +    return unscaleLon(scaleLon(result));
> >>    }
> >>
> >>    protected GeoRect randomRect(boolean small, boolean
> canCrossDateLine)
> >> {
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: dev-help@lucene.apache.org
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: lucene-solr git commit: revert this est change until we can fix geo API border cases (LUCENE-6956)

Posted by Michael McCandless <lu...@mikemccandless.com>.
Argh!!!

My ~/.gitconfig has:

[user]
  email = mikemccand@apache.org
  name = Mike McCandless

Which I think the "git config --global user.name ..." did ...

I'll try to figure why my commits are the wrong username.

Mike McCandless

http://blog.mikemccandless.com


On Sun, Jan 24, 2016 at 4:52 PM, Uwe Schindler <uw...@thetaphi.de> wrote:
> Hi,
>
> you have still the wrong mail address for the GIT commit itsself:
>> Author: Michael McCandless <ma...@mikemccandless.com>
>> Authored: Sun Jan 24 16:48:51 2016 -0500
>
> The person who pushed is different:
>> Committer: Mike McCandless <mi...@apache.org>
>> Committed: Sun Jan 24 16:48:51 2016 -0500
>
> Uwe
>
> -----
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
> http://www.thetaphi.de
> eMail: uwe@thetaphi.de
>
>
>> -----Original Message-----
>> From: mikemccand@apache.org [mailto:mikemccand@apache.org]
>> Sent: Sunday, January 24, 2016 10:49 PM
>> To: commits@lucene.apache.org
>> Subject: lucene-solr git commit: revert this est change until we can fix geo
>> API border cases (LUCENE-6956)
>>
>> Repository: lucene-solr
>> Updated Branches:
>>   refs/heads/master 9d35aafc5 -> b62c6715d
>>
>>
>> revert this est change until we can fix geo API border cases (LUCENE-6956)
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/lucene-
>> solr/commit/b62c6715
>> Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/b62c6715
>> Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/b62c6715
>>
>> Branch: refs/heads/master
>> Commit: b62c6715df12616785732cc1011e11fe4faa16ca
>> Parents: 9d35aaf
>> Author: Michael McCandless <ma...@mikemccandless.com>
>> Authored: Sun Jan 24 16:48:51 2016 -0500
>> Committer: Mike McCandless <mi...@apache.org>
>> Committed: Sun Jan 24 16:48:51 2016 -0500
>>
>> ----------------------------------------------------------------------
>>  .../src/test/org/apache/lucene/util/BaseGeoPointTestCase.java  | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/lucene-
>> solr/blob/b62c6715/lucene/sandbox/src/test/org/apache/lucene/util/BaseG
>> eoPointTestCase.java
>> ----------------------------------------------------------------------
>> diff --git
>> a/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.j
>> ava
>> b/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.j
>> ava
>> index f84d696..4236e88 100644
>> ---
>> a/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.j
>> ava
>> +++
>> b/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.j
>> ava
>> @@ -434,7 +434,8 @@ public abstract class BaseGeoPointTestCase extends
>> LuceneTestCase {
>>      } else {
>>        result = -90 + 180.0 * random().nextDouble();
>>      }
>> -    return result;
>> +    // TODO: we should not do this here!  it weakens the test, and users don't
>> pre-quantize the lat/lons they send us:
>> +    return unscaleLat(scaleLat(result));
>>    }
>>
>>    public double randomLon(boolean small) {
>> @@ -444,7 +445,8 @@ public abstract class BaseGeoPointTestCase extends
>> LuceneTestCase {
>>      } else {
>>        result = -180 + 360.0 * random().nextDouble();
>>      }
>> -    return result;
>> +    // TODO: we should not do this here!  it weakens the test, and users don't
>> pre-quantize the lat/lons they send us:
>> +    return unscaleLon(scaleLon(result));
>>    }
>>
>>    protected GeoRect randomRect(boolean small, boolean canCrossDateLine)
>> {
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


RE: lucene-solr git commit: revert this est change until we can fix geo API border cases (LUCENE-6956)

Posted by Uwe Schindler <uw...@thetaphi.de>.
Hi,

you have still the wrong mail address for the GIT commit itsself:
> Author: Michael McCandless <ma...@mikemccandless.com>
> Authored: Sun Jan 24 16:48:51 2016 -0500

The person who pushed is different:
> Committer: Mike McCandless <mi...@apache.org>
> Committed: Sun Jan 24 16:48:51 2016 -0500

Uwe

-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de


> -----Original Message-----
> From: mikemccand@apache.org [mailto:mikemccand@apache.org]
> Sent: Sunday, January 24, 2016 10:49 PM
> To: commits@lucene.apache.org
> Subject: lucene-solr git commit: revert this est change until we can fix geo
> API border cases (LUCENE-6956)
> 
> Repository: lucene-solr
> Updated Branches:
>   refs/heads/master 9d35aafc5 -> b62c6715d
> 
> 
> revert this est change until we can fix geo API border cases (LUCENE-6956)
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
> Commit: http://git-wip-us.apache.org/repos/asf/lucene-
> solr/commit/b62c6715
> Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/b62c6715
> Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/b62c6715
> 
> Branch: refs/heads/master
> Commit: b62c6715df12616785732cc1011e11fe4faa16ca
> Parents: 9d35aaf
> Author: Michael McCandless <ma...@mikemccandless.com>
> Authored: Sun Jan 24 16:48:51 2016 -0500
> Committer: Mike McCandless <mi...@apache.org>
> Committed: Sun Jan 24 16:48:51 2016 -0500
> 
> ----------------------------------------------------------------------
>  .../src/test/org/apache/lucene/util/BaseGeoPointTestCase.java  | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/lucene-
> solr/blob/b62c6715/lucene/sandbox/src/test/org/apache/lucene/util/BaseG
> eoPointTestCase.java
> ----------------------------------------------------------------------
> diff --git
> a/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.j
> ava
> b/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.j
> ava
> index f84d696..4236e88 100644
> ---
> a/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.j
> ava
> +++
> b/lucene/sandbox/src/test/org/apache/lucene/util/BaseGeoPointTestCase.j
> ava
> @@ -434,7 +434,8 @@ public abstract class BaseGeoPointTestCase extends
> LuceneTestCase {
>      } else {
>        result = -90 + 180.0 * random().nextDouble();
>      }
> -    return result;
> +    // TODO: we should not do this here!  it weakens the test, and users don't
> pre-quantize the lat/lons they send us:
> +    return unscaleLat(scaleLat(result));
>    }
> 
>    public double randomLon(boolean small) {
> @@ -444,7 +445,8 @@ public abstract class BaseGeoPointTestCase extends
> LuceneTestCase {
>      } else {
>        result = -180 + 360.0 * random().nextDouble();
>      }
> -    return result;
> +    // TODO: we should not do this here!  it weakens the test, and users don't
> pre-quantize the lat/lons they send us:
> +    return unscaleLon(scaleLon(result));
>    }
> 
>    protected GeoRect randomRect(boolean small, boolean canCrossDateLine)
> {


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org