Re: [I] ”InlineShardingAlgorithm“ It's not thread-safe， Occasionally the following errors occur: Cause: java.sql.SQLException: Unknown exception: Cannot invoke method hashCode() on null object [shardingsphere]

["linghengqian (via GitHub)" <gi...@apache.org>]

linghengqian commented on issue #33339:
URL: https://github.com/apache/shardingsphere/issues/33339#issuecomment-2428747985

   - This change was originally introduced by the SPI I designed, but it did not break existing unit tests. Can you open a PR with the new unit tests? Or provide a git repository with the unit tests? There has been a lack of attention paid to the handling of groovyshell class instances.
   
   - By the way, the reason I introduced changes in this algorithm class is to get rid of groovy in the master branch of shardingsphere. It is not reasonable to use a specific SPI implementation class in `#init()`. Potential implementations of Python, JavaScript, Ruby, and WASM Row Value Expressions may still be put into this Java class. However, the relevant proposal was initially blocked by an issue on the GraalVM CE side. With the decoupling of GraalVM Truffle from the GraalVM SDK, I can re-examine the design of the relevant SPI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org