[GitHub] [opennlp] kinow commented on a diff in pull request #410: OPENNLP-1351: Moving onnx models for testing. Fixing expected value.

[GitBox <gi...@apache.org>]

kinow commented on code in PR #410:
URL: https://github.com/apache/opennlp/pull/410#discussion_r846887262


##########
opennlp-dl/src/test/java/opennlp/dl/namefinder/NameFinderDLEval.java:
##########
@@ -54,7 +54,7 @@ public void tokenNameFinder1Test() throws Exception {
     Assert.assertEquals(1, spans.length);
     Assert.assertEquals(0, spans[0].getStart());
     Assert.assertEquals(2, spans[0].getEnd());
-    Assert.assertEquals(0.8251646041870118, spans[0].getProb(), 0.0);
+    Assert.assertEquals(8.251646041870117, spans[0].getProb(), 0.0);

Review Comment:
   Only part that called my attention in the PR. I guess it's just some calculation that changed somewhere, and since it's in the tests, it shouldn't really matter, I think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org