[GitHub] [ozone] errose28 commented on a diff in pull request #4995: HDDS-8062. Persist reason for container replica being marked unhealthy.

["errose28 (via GitHub)" <gi...@apache.org>]

errose28 commented on code in PR #4995:
URL: https://github.com/apache/ozone/pull/4995#discussion_r1253638934


##########
hadoop-ozone/dist/src/shell/ozone/ozone:
##########
@@ -121,6 +121,7 @@ function ozonecmd_case
       ozone_deprecate_envvar HDDS_DN_OPTS OZONE_DATANODE_OPTS
       OZONE_DATANODE_OPTS="${RATIS_OPTS} ${OZONE_DATANODE_OPTS}"
       OZONE_DATANODE_OPTS="-Dlog4j.configurationFile=${OZONE_CONF_DIR}/dn-audit-log4j2.properties ${OZONE_DATANODE_OPTS}"
+      OZONE_DATANODE_OPTS="-Dlog4j.configurationFile=${OZONE_CONF_DIR}/dn-container-log4j2.properties ${OZONE_DATANODE_OPTS}"

Review Comment:
   Right, it should be a comma separated list as specified [here](https://logging.apache.org/log4j/2.x/manual/configuration.html#SystemProperties). I updated the code.
   
   > Also check if both logs are commit at same point of time, like merge, instead of overwrite for global configuration
   
   I'm not sure what is meant by this comment, can you explain a bit more?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org