[jira] [Commented] (AURORA-1327) MesosSchedulerImpl should check if reason is present when posting status updates

["Zameer Manji (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AURORA-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569930#comment-14569930 ] 

Zameer Manji commented on AURORA-1327:
--------------------------------------

I added this to the backlog because this currently skews the task_exit_ metrics. [~joshua.cohen], do you see yourself working on this anytime soon?

> MesosSchedulerImpl should check if reason is present when posting status updates
> --------------------------------------------------------------------------------
>
>                 Key: AURORA-1327
>                 URL: https://issues.apache.org/jira/browse/AURORA-1327
>             Project: Aurora
>          Issue Type: Task
>          Components: Scheduler
>            Reporter: Joshua Cohen
>
> We export stats based on task statuses, however since protobuf enums default to a value when unset, the reason stats we generate may not be correct. c.f https://github.com/apache/aurora/blob/998993dd802cf5e94a995aefd7a6c4ec90a1d3af/src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java#L228. If reason is unset, it will default to the first enum value ({{REASON_COMMAND_EXECUTOR_FAILED}}).
> We should call {{status.hasReason()}} first and if it's not set, do not use the value of {{status.getReason()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)