You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Yifan Gu <yi...@mesosphere.io> on 2014/07/15 20:03:17 UTC
Review Request 23506: Refactored docker::usage() and docker::run().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23506/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Timothy Chen.
Bugs: MESOS-1524
https://issues.apache.org/jira/browse/MESOS-1524
Repository: mesos-git
Description
-------
Support resources restriction in docker::run().
Support resources display in docker::usage().
Also fixed docker::usage() to check for destroying containers
before calling docker::inspect().
Diffs
-----
src/docker/docker.hpp PRE-CREATION
src/docker/docker.cpp PRE-CREATION
src/slave/containerizer/docker.cpp PRE-CREATION
src/tests/docker_containerizer_tests.cpp PRE-CREATION
src/tests/docker_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/23506/diff/
Testing
-------
make check
Thanks,
Yifan Gu
Re: Review Request 23506: Refactored docker::usage() and docker::run().
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23506/#review47905
-----------------------------------------------------------
Bad patch!
Reviews applied: [23506]
Failed command: git apply --index 23506.patch
Error:
error: src/docker/docker.hpp: does not exist in index
error: src/docker/docker.cpp: does not exist in index
error: src/slave/containerizer/docker.cpp: does not exist in index
error: src/tests/docker_containerizer_tests.cpp: does not exist in index
error: src/tests/docker_tests.cpp: does not exist in index
- Mesos ReviewBot
On July 15, 2014, 6:03 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23506/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 6:03 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Timothy Chen.
>
>
> Bugs: MESOS-1524
> https://issues.apache.org/jira/browse/MESOS-1524
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Support resources restriction in docker::run().
> Support resources display in docker::usage().
> Also fixed docker::usage() to check for destroying containers
> before calling docker::inspect().
>
>
> Diffs
> -----
>
> src/docker/docker.hpp PRE-CREATION
> src/docker/docker.cpp PRE-CREATION
> src/slave/containerizer/docker.cpp PRE-CREATION
> src/tests/docker_containerizer_tests.cpp PRE-CREATION
> src/tests/docker_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23506/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 23506: Refactored docker::usage() and docker::run().
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23506/
-----------------------------------------------------------
(Updated July 17, 2014, 7:48 p.m.)
Review request for mesos, Benjamin Hindman and Timothy Chen.
Bugs: MESOS-1524
https://issues.apache.org/jira/browse/MESOS-1524
Repository: mesos-git
Description
-------
Support resources restriction in docker::run().
Support resources display in docker::usage().
Also fixed docker::usage() to check for destroying containers
before calling docker::inspect().
Diffs
-----
src/docker/docker.hpp PRE-CREATION
src/docker/docker.cpp PRE-CREATION
src/slave/containerizer/docker.cpp PRE-CREATION
src/tests/docker_containerizer_tests.cpp PRE-CREATION
src/tests/docker_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/23506/diff/
Testing
-------
make check
Thanks,
Yifan Gu