You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/13 11:36:15 UTC

[GitHub] [flink] TsReaper opened a new pull request #10174: [FLINK-14625][table-planner-blink] Add a rule to eliminate cross join as much as possible without statistics

TsReaper opened a new pull request #10174: [FLINK-14625][table-planner-blink] Add a rule to eliminate cross join as much as possible without statistics
URL: https://github.com/apache/flink/pull/10174
 
 
   # What is the purpose of the change
   
   This PR introduces a rule to eliminate cross join as much as possible (the EliminateCrossJoinRule) without the help of statistics. A detailed explanation of this rule can be seen [here](https://issues.apache.org/jira/browse/FLINK-14625?focusedCommentId=16973011&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16973011).
   
   As the newly introduced rule is in conflict with the cost-based join reorder rule in some extent, the old "table.optimizer.join-reorder-enabled" config key is now deprecated. This PR also introduces a new "table.optimizer.join-reorder-mode" config key to select which join reorder rule to apply (NONE, ELIMINATE_CROSS_JOIN or COST_BASED).
   
   ## Brief change log
     - Introduce the new EliminateCrossJoinRule.
     - Deprecate "table.optimizer.join-reorder-enabled" and add a new config key "table.optimizer.join-reorder-mode".
   
   ## Verifying this change
   
   This change added tests and can be verified as follows: run the newly added EliminateCrossJoinRuleTest
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? docs
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services