You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by li...@apache.org on 2015/05/16 14:57:01 UTC
spark git commit: [HOTFIX] [SQL] Fixes DataFrameWriter.mode(String)
Repository: spark
Updated Branches:
refs/heads/master 47e7ffe36 -> ce6391296
[HOTFIX] [SQL] Fixes DataFrameWriter.mode(String)
We forgot an assignment there.
/cc rxin
Author: Cheng Lian <li...@databricks.com>
Closes #6212 from liancheng/fix-df-writer and squashes the following commits:
711fbb0 [Cheng Lian] Adds a test case
3b72d78 [Cheng Lian] Fixes DataFrameWriter.mode(String)
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/ce639129
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/ce639129
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/ce639129
Branch: refs/heads/master
Commit: ce6391296a061bc352386080a2ee96bb63fcc4ac
Parents: 47e7ffe
Author: Cheng Lian <li...@databricks.com>
Authored: Sat May 16 20:55:10 2015 +0800
Committer: Cheng Lian <li...@databricks.com>
Committed: Sat May 16 20:55:17 2015 +0800
----------------------------------------------------------------------
.../src/main/scala/org/apache/spark/sql/DataFrameWriter.scala | 2 +-
.../scala/org/apache/spark/sql/sources/SaveLoadSuite.scala | 7 +++++++
2 files changed, 8 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/ce639129/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala b/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
index b1fc18a..9f42f0f 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
@@ -55,7 +55,7 @@ final class DataFrameWriter private[sql](df: DataFrame) {
* @since 1.4.0
*/
def mode(saveMode: String): DataFrameWriter = {
- saveMode.toLowerCase match {
+ this.mode = saveMode.toLowerCase match {
case "overwrite" => SaveMode.Overwrite
case "append" => SaveMode.Append
case "ignore" => SaveMode.Ignore
http://git-wip-us.apache.org/repos/asf/spark/blob/ce639129/sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala
index 7a28e9a..274c652 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala
@@ -75,6 +75,13 @@ class SaveLoadSuite extends DataSourceTest with BeforeAndAfterAll {
checkLoad()
}
+ test("save with string mode and path, and load") {
+ conf.setConf(SQLConf.DEFAULT_DATA_SOURCE_NAME, "org.apache.spark.sql.json")
+ path.createNewFile()
+ df.write.mode("overwrite").save(path.toString)
+ checkLoad()
+ }
+
test("save with path and datasource, and load") {
conf.setConf(SQLConf.DEFAULT_DATA_SOURCE_NAME, "not a source name")
df.write.json(path.toString)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org