You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "nicolasge (via GitHub)" <gi...@apache.org> on 2024/09/13 06:35:50 UTC

[I] Hardcoded Opentelemetry SERVICE_NAME [airflow]

nicolasge opened a new issue, #42210:
URL: https://github.com/apache/airflow/issues/42210

   ### Apache Airflow version
   
   2.10.1
   
   ### If "Other Airflow 2 version" selected, which one?
   
   _No response_
   
   ### What happened?
   
   When enabled the OTEL in Airflow, the OTEL_SERVICE_NAME is hardcoded to "Airflow".  Based on https://opentelemetry.io/docs/languages/sdk-configuration/general/ users should be able to overwrite this to any value via environment variable OTEL_SERVICE_NAME.
   
   Image code path: /home/airflow/.local/lib/python3.12/site-packages/airflow/metrics/otel_logger.py
   Bug line:  resource = Resource(attributes={SERVICE_NAME: "Airflow"})
   
   ### What you think should happen instead?
   
   If user specified OTEL_SERVICE_NAME via environment, airflow use should this value instead of hardcoded value which is "Airflow"
   
   ### How to reproduce
   
   During the installation, inject an extra environment OTEL_SERVICE_NAME and set the value to a value not equal to Airflow
   
   ### Operating System
   
   Debian 12
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Official Apache Airflow Helm Chart
   
   ### Deployment details
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Hardcoded Opentelemetry SERVICE_NAME [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on issue #42210:
URL: https://github.com/apache/airflow/issues/42210#issuecomment-2348142684

   Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Hardcoded Opentelemetry SERVICE_NAME [airflow]

Posted by "nicolasge (via GitHub)" <gi...@apache.org>.
nicolasge commented on issue #42210:
URL: https://github.com/apache/airflow/issues/42210#issuecomment-2360834093

   It looks good to me.  Thanks @romsharon98 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Hardcoded Opentelemetry SERVICE_NAME [airflow]

Posted by "romsharon98 (via GitHub)" <gi...@apache.org>.
romsharon98 closed issue #42210: Hardcoded Opentelemetry SERVICE_NAME
URL: https://github.com/apache/airflow/issues/42210


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Hardcoded Opentelemetry SERVICE_NAME [airflow]

Posted by "romsharon98 (via GitHub)" <gi...@apache.org>.
romsharon98 commented on issue #42210:
URL: https://github.com/apache/airflow/issues/42210#issuecomment-2351294115

   Apparently `otel` configuration already have  `service_name` configuration, I duplicate it to the metrics section and apply it on the service name.
   
   Let me know what you think on the [PR](https://github.com/apache/airflow/pull/42242)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org