You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/25 00:51:41 UTC

[GitHub] [beam] ibzib commented on a change in pull request #14332: [BEAM-12033] Validate casts from double literals to numeric during ex…

ibzib commented on a change in pull request #14332:
URL: https://github.com/apache/beam/pull/14332#discussion_r600968387



##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##########
@@ -163,6 +164,15 @@
           + " The date_part includes: "
           + INTERVAL_DATE_PART_MSG;
 
+  // Maximum and minimum allowed values for the NUMERIC/DECIMAL data type.
+  // https://github.com/google/zetasql/blob/master/docs/data-types.md#decimal-type
+  private static final BigDecimal MAX_NUMERIC_VALUE =

Review comment:
       That class is in the testing package.
   
   For the record, the same constants are also defined in ZetaSQL Java, but they're private.
   
   https://github.com/google/zetasql/blob/697da738be2af3b6b9492c73c55616d8b9fed0b6/java/com/google/zetasql/Value.java#L102-L105




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org