You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "xdshent (via GitHub)" <gi...@apache.org> on 2023/06/13 02:56:54 UTC
[GitHub] [rocketmq] xdshent opened a new pull request, #6898: fix: the `ArrayIndexOutOfBoundsException` exception that may occur when selecting a queue
xdshent opened a new pull request, #6898:
URL: https://github.com/apache/rocketmq/pull/6898
### Which Issue(s) This PR Fixes
Fixes #6897
### Brief Description
<img width="799" alt="image" src="https://github.com/apache/rocketmq/assets/16759505/c3507b53-c05a-4bf6-9269-435e2c533383">
* The incrementAndGet() method returns the maximum value of Integer.
* Executing the index++ inside the loop again may result in a negative number, leading to ArrayIndexOutOfBoundsException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #6897]fix: the `ArrayIndexOutOfBoundsException` exception that may occur when selecting a queue [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6898:
URL: https://github.com/apache/rocketmq/pull/6898#issuecomment-2171948904
This PR was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6898: fix: the `ArrayIndexOutOfBoundsException` exception that may occur when selecting a queue
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6898:
URL: https://github.com/apache/rocketmq/pull/6898#issuecomment-1588462492
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/6898?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#6898](https://app.codecov.io/gh/apache/rocketmq/pull/6898?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c0acae8) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/ad4cc957fb4bf9560b70c4fc346f64a42f79ee14?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ad4cc95) will **increase** coverage by `0.06%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## develop #6898 +/- ##
=============================================
+ Coverage 42.65% 42.71% +0.06%
- Complexity 9101 9112 +11
=============================================
Files 1125 1125
Lines 79875 79875
Branches 10383 10383
=============================================
+ Hits 34071 34121 +50
+ Misses 41527 41479 -48
+ Partials 4277 4275 -2
```
| [Impacted Files](https://app.codecov.io/gh/apache/rocketmq/pull/6898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...pache/rocketmq/client/latency/MQFaultStrategy.java](https://app.codecov.io/gh/apache/rocketmq/pull/6898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvbGF0ZW5jeS9NUUZhdWx0U3RyYXRlZ3kuamF2YQ==) | `18.18% <0.00%> (ø)` | |
... and [23 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/6898/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #6897]fix: the `ArrayIndexOutOfBoundsException` exception that may occur when selecting a queue [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6898:
URL: https://github.com/apache/rocketmq/pull/6898#issuecomment-2166984389
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #6897]fix: the `ArrayIndexOutOfBoundsException` exception that may occur when selecting a queue [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #6898: [ISSUE #6897]fix: the `ArrayIndexOutOfBoundsException` exception that may occur when selecting a queue
URL: https://github.com/apache/rocketmq/pull/6898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ferrirW commented on pull request #6898: [ISSUE #6897]fix: the `ArrayIndexOutOfBoundsException` exception that may occur when selecting a queue
Posted by "ferrirW (via GitHub)" <gi...@apache.org>.
ferrirW commented on PR #6898:
URL: https://github.com/apache/rocketmq/pull/6898#issuecomment-1591182832
IMO, Maybe should revert this pr: https://github.com/apache/rocketmq/pull/5181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org