You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/28 16:32:22 UTC

[GitHub] [iceberg] Flyangz commented on a change in pull request #2875: Core: added includeColumnStats option in FindFiles API

Flyangz commented on a change in pull request #2875:
URL: https://github.com/apache/iceberg/pull/2875#discussion_r678469274



##########
File path: core/src/main/java/org/apache/iceberg/FindFiles.java
##########
@@ -206,7 +212,8 @@ public Builder inPartitions(PartitionSpec spec, List<StructLike> partitions) {
           .caseSensitive(caseSensitive)
           .entries();
 
-      return CloseableIterable.transform(entries, entry -> entry.file().copyWithoutStats());
+      return CloseableIterable.transform(entries,
+          entry -> includeColumnStats ? entry.file().copy() : entry.file().copyWithoutStats());

Review comment:
       Thanks reply. I have added the unit test, please check it out.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org