You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Adam Faris (JIRA)" <ji...@apache.org> on 2010/08/18 00:59:16 UTC
[jira] Created: (TS-418) AdminClient.pm has invalid package path,
preventing it's use without modification.
AdminClient.pm has invalid package path, preventing it's use without modification.
----------------------------------------------------------------------------------
Key: TS-418
URL: https://issues.apache.org/jira/browse/TS-418
Project: Traffic Server
Issue Type: Bug
Components: Stats
Reporter: Adam Faris
Priority: Minor
AdminClient.pm found under 'contrib' in cvs (http://svn.apache.org/viewvc/trafficserver/traffic/trunk/contrib/) has a couple of issues.
---------
1) there's no pod or perl documentation
2) there's no MakeFile to help with placing AdminClient.pm in the proper directory so @INC will find it.
3) the package statement is flawed as it's not in a Apache/TS/ directory structure. To use the current AdminClient.pm, one would need to modify the 'package' statement by hand.
---------
I have a local copy where the above issues are fixed, but have questions about the v2 stats on port 8091. Specifically, will future stats use port 8091 (or whatever proxy.config.stat_collector.port is set to) or will stats continue to be read from the 'unix domain socket' which currently defaults to /usr/local/var/trafficserver/cli. If someone who knows can update this ticket, I can make those additions/changes before committing to SVN.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (TS-418) AdminClient.pm has invalid
package path, preventing it's use without modification.
Posted by "Adam Faris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899680#action_12899680 ]
Adam Faris edited comment on TS-418 at 8/17/10 9:00 PM:
--------------------------------------------------------
Here's a tar file containing the changes I mentioned. I'm submitting as a tar file as it contains a directory structure which was created by h2xs. I started to write this to be released to cpan but decided against it as there's no sense in having two copies of the same package floating around the internet. Also publishing to cpan would open other issues, like who from the dev team can upload updates to cpan; so yes, leave AdminClient with ATS. Anyway that's the reasoning behind the '-0.01' extension on the parent directory name.
Part of h2xs process results in a Makefile which does the actual install of the module. The README has the details, but it seems reasonable that in the future we could incorporate that h2xs Makefile into the ATS install scripts. Let me know if I've overlooked something and I'll be happy to make the changes.
Regarding port 8091, it's not being used by AdminClient. All requests are using the unix domain socket.
was (Author: farisa):
Here's a tar file containing the changes I mentioned. I'm submitting as a tar file as it contains a directory structure which was created by h2xs. I started to write this to be released to cpan but decided against it as there's no sense in having two copies of the same package floating around the internet. Also publishing to cpan would open other issues, like who from the dev team can upload updates to cpan; so yes, leave AdminClient with ATS. Anyway that's the reasoning behind the '-0.01' extension on the parent directory name.
Part of h2xs process results in a Makefile which does the actual install of the module. The README has the details, but it seems reasonable that in the future we could incorporate that h2xs Makefile into the ATS install scripts. Let me know if I've overlooked something and I'll be happy to make the changes.
> AdminClient.pm has invalid package path, preventing it's use without modification.
> ----------------------------------------------------------------------------------
>
> Key: TS-418
> URL: https://issues.apache.org/jira/browse/TS-418
> Project: Traffic Server
> Issue Type: Bug
> Components: Stats
> Reporter: Adam Faris
> Priority: Minor
> Attachments: AdminClient.tgz
>
> Original Estimate: 25h
> Remaining Estimate: 25h
>
> AdminClient.pm found under 'contrib' in cvs (http://svn.apache.org/viewvc/trafficserver/traffic/trunk/contrib/) has a couple of issues.
> ---------
> 1) there's no pod or perl documentation
> 2) there's no MakeFile to help with placing AdminClient.pm in the proper directory so @INC will find it.
> 3) the package statement is flawed as it's not in a Apache/TS/ directory structure. To use the current AdminClient.pm, one would need to modify the 'package' statement by hand.
> ---------
> I have a local copy where the above issues are fixed, but have questions about the v2 stats on port 8091. Specifically, will future stats use port 8091 (or whatever proxy.config.stat_collector.port is set to) or will stats continue to be read from the 'unix domain socket' which currently defaults to /usr/local/var/trafficserver/cli. If someone who knows can update this ticket, I can make those additions/changes before committing to SVN.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TS-418) AdminClient.pm has invalid package path,
preventing it's use without modification.
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom reassigned TS-418:
--------------------------------
Assignee: Leif Hedstrom
> AdminClient.pm has invalid package path, preventing it's use without modification.
> ----------------------------------------------------------------------------------
>
> Key: TS-418
> URL: https://issues.apache.org/jira/browse/TS-418
> Project: Traffic Server
> Issue Type: Bug
> Components: Stats
> Reporter: Adam Faris
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 2.1.3
>
> Attachments: AdminClient.tgz
>
> Original Estimate: 25h
> Remaining Estimate: 25h
>
> AdminClient.pm found under 'contrib' in cvs (http://svn.apache.org/viewvc/trafficserver/traffic/trunk/contrib/) has a couple of issues.
> ---------
> 1) there's no pod or perl documentation
> 2) there's no MakeFile to help with placing AdminClient.pm in the proper directory so @INC will find it.
> 3) the package statement is flawed as it's not in a Apache/TS/ directory structure. To use the current AdminClient.pm, one would need to modify the 'package' statement by hand.
> ---------
> I have a local copy where the above issues are fixed, but have questions about the v2 stats on port 8091. Specifically, will future stats use port 8091 (or whatever proxy.config.stat_collector.port is set to) or will stats continue to be read from the 'unix domain socket' which currently defaults to /usr/local/var/trafficserver/cli. If someone who knows can update this ticket, I can make those additions/changes before committing to SVN.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-418) AdminClient.pm has invalid package path,
preventing it's use without modification.
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899649#action_12899649 ]
Leif Hedstrom commented on TS-418:
----------------------------------
My strong preference would be to eliminate port 8091, and only use the unix domain socket for all stats. Or at a minimum, there should only be one way of accessing "stats" and "configurations" from command line.
I started working a little on a proposal for how to clean up the stats, there's a rough draft at
https://cwiki.apache.org/confluence/display/TS/NewStatsAPI
> AdminClient.pm has invalid package path, preventing it's use without modification.
> ----------------------------------------------------------------------------------
>
> Key: TS-418
> URL: https://issues.apache.org/jira/browse/TS-418
> Project: Traffic Server
> Issue Type: Bug
> Components: Stats
> Reporter: Adam Faris
> Priority: Minor
> Original Estimate: 25h
> Remaining Estimate: 25h
>
> AdminClient.pm found under 'contrib' in cvs (http://svn.apache.org/viewvc/trafficserver/traffic/trunk/contrib/) has a couple of issues.
> ---------
> 1) there's no pod or perl documentation
> 2) there's no MakeFile to help with placing AdminClient.pm in the proper directory so @INC will find it.
> 3) the package statement is flawed as it's not in a Apache/TS/ directory structure. To use the current AdminClient.pm, one would need to modify the 'package' statement by hand.
> ---------
> I have a local copy where the above issues are fixed, but have questions about the v2 stats on port 8091. Specifically, will future stats use port 8091 (or whatever proxy.config.stat_collector.port is set to) or will stats continue to be read from the 'unix domain socket' which currently defaults to /usr/local/var/trafficserver/cli. If someone who knows can update this ticket, I can make those additions/changes before committing to SVN.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-418) AdminClient.pm has invalid package path,
preventing it's use without modification.
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-418:
-----------------------------
Fix Version/s: 2.1.3
> AdminClient.pm has invalid package path, preventing it's use without modification.
> ----------------------------------------------------------------------------------
>
> Key: TS-418
> URL: https://issues.apache.org/jira/browse/TS-418
> Project: Traffic Server
> Issue Type: Bug
> Components: Stats
> Reporter: Adam Faris
> Priority: Minor
> Fix For: 2.1.3
>
> Attachments: AdminClient.tgz
>
> Original Estimate: 25h
> Remaining Estimate: 25h
>
> AdminClient.pm found under 'contrib' in cvs (http://svn.apache.org/viewvc/trafficserver/traffic/trunk/contrib/) has a couple of issues.
> ---------
> 1) there's no pod or perl documentation
> 2) there's no MakeFile to help with placing AdminClient.pm in the proper directory so @INC will find it.
> 3) the package statement is flawed as it's not in a Apache/TS/ directory structure. To use the current AdminClient.pm, one would need to modify the 'package' statement by hand.
> ---------
> I have a local copy where the above issues are fixed, but have questions about the v2 stats on port 8091. Specifically, will future stats use port 8091 (or whatever proxy.config.stat_collector.port is set to) or will stats continue to be read from the 'unix domain socket' which currently defaults to /usr/local/var/trafficserver/cli. If someone who knows can update this ticket, I can make those additions/changes before committing to SVN.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-418) AdminClient.pm has invalid package path,
preventing it's use without modification.
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom resolved TS-418.
------------------------------
Resolution: Fixed
Committed this, the new "tree" is
contrib/perl
└── AdminClient
├── Changes
├── lib
│ └── Apache
│ └── TS
│ └── AdminClient.pm
├── Makefile.PL
├── MANIFEST
├── README
└── t
└── Apache-TS-AdminClient.t
> AdminClient.pm has invalid package path, preventing it's use without modification.
> ----------------------------------------------------------------------------------
>
> Key: TS-418
> URL: https://issues.apache.org/jira/browse/TS-418
> Project: Traffic Server
> Issue Type: Bug
> Components: Stats
> Reporter: Adam Faris
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 2.1.3
>
> Attachments: AdminClient.tgz
>
> Original Estimate: 25h
> Remaining Estimate: 25h
>
> AdminClient.pm found under 'contrib' in cvs (http://svn.apache.org/viewvc/trafficserver/traffic/trunk/contrib/) has a couple of issues.
> ---------
> 1) there's no pod or perl documentation
> 2) there's no MakeFile to help with placing AdminClient.pm in the proper directory so @INC will find it.
> 3) the package statement is flawed as it's not in a Apache/TS/ directory structure. To use the current AdminClient.pm, one would need to modify the 'package' statement by hand.
> ---------
> I have a local copy where the above issues are fixed, but have questions about the v2 stats on port 8091. Specifically, will future stats use port 8091 (or whatever proxy.config.stat_collector.port is set to) or will stats continue to be read from the 'unix domain socket' which currently defaults to /usr/local/var/trafficserver/cli. If someone who knows can update this ticket, I can make those additions/changes before committing to SVN.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-418) AdminClient.pm has invalid package path,
preventing it's use without modification.
Posted by "Adam Faris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Faris updated TS-418:
--------------------------
Attachment: AdminClient.tgz
Here's a tar file containing the changes I mentioned. I'm submitting as a tar file as it contains a directory structure which was created by h2xs. I started to write this to be released to cpan but decided against it as there's no sense in having two copies of the same package floating around the internet. Also publishing to cpan would open other issues, like who from the dev team can upload updates to cpan; so yes, leave AdminClient with ATS. Anyway that's the reasoning behind the '-0.01' extension on the parent directory name.
Part of h2xs process results in a Makefile which does the actual install of the module. The README has the details, but it seems reasonable that in the future we could incorporate that h2xs Makefile into the ATS install scripts. Let me know if I've overlooked something and I'll be happy to make the changes.
> AdminClient.pm has invalid package path, preventing it's use without modification.
> ----------------------------------------------------------------------------------
>
> Key: TS-418
> URL: https://issues.apache.org/jira/browse/TS-418
> Project: Traffic Server
> Issue Type: Bug
> Components: Stats
> Reporter: Adam Faris
> Priority: Minor
> Attachments: AdminClient.tgz
>
> Original Estimate: 25h
> Remaining Estimate: 25h
>
> AdminClient.pm found under 'contrib' in cvs (http://svn.apache.org/viewvc/trafficserver/traffic/trunk/contrib/) has a couple of issues.
> ---------
> 1) there's no pod or perl documentation
> 2) there's no MakeFile to help with placing AdminClient.pm in the proper directory so @INC will find it.
> 3) the package statement is flawed as it's not in a Apache/TS/ directory structure. To use the current AdminClient.pm, one would need to modify the 'package' statement by hand.
> ---------
> I have a local copy where the above issues are fixed, but have questions about the v2 stats on port 8091. Specifically, will future stats use port 8091 (or whatever proxy.config.stat_collector.port is set to) or will stats continue to be read from the 'unix domain socket' which currently defaults to /usr/local/var/trafficserver/cli. If someone who knows can update this ticket, I can make those additions/changes before committing to SVN.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.