You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Phil Steitz <ph...@gmail.com> on 2010/02/07 19:55:43 UTC

[VOTE] Release DBCP 1.3/1.4 based on RC7

Having corrected the problems identified with RC6 (unit test timing
errors, unnecessary trivial object caches, unnecessary mutability in
CPDS factories, incomplete fix for DBCP-8), I would like to move
forward with the release of DBCP 1.3/1.4.

As previously discussed, the only difference between
1.3 and 1.4 is that the 1.3 sources have been filtered to exclude
JDBC4 methods.  Version 1.3 is for JDK 1.4-1.5 and only builds under
one of these JDKs.  Note that to execute the 1.3 maven build under
JDK 1.4 you need a 2.0.x version of maven.

Here are the artifacts:

1.3 (JDBC 3) version:
http://people.apache.org/~psteitz/dbcp-1.3-rc7
http://people.apache.org/~psteitz/dbcp-1.3-rc7/site
http://people.apache.org/~psteitz/dbcp-1.3-rc7/maven
http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC7/

1.4 (JDBC 4) version:
http://people.apache.org/~psteitz/dbcp-1.4-rc7
http://people.apache.org/~psteitz/dbcp-1.4-rc7/site
http://people.apache.org/~psteitz/dbcp-1.4-rc7/maven
http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC7/

Release notes (common version, ships with both)
http://people.apache.org/~psteitz/RELEASE-NOTES.txt

Votes, please. This VOTE will close 10-February-2010 19:00 GMT.

[ ] +1 Proceed with release
[ ] +0 OK
[ ] -0 OK, but I would prefer...
[ ] -1 No, showstopper = ...

Thanks!

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release DBCP 1.3/1.4 based on RC7

Posted by Phil Steitz <ph...@gmail.com>.
sebb wrote:
> On 07/02/2010, Phil Steitz <ph...@gmail.com> wrote:
>> Having corrected the problems identified with RC6 (unit test timing
>>  errors, unnecessary trivial object caches, unnecessary mutability in
>>  CPDS factories, incomplete fix for DBCP-8), I would like to move
>>  forward with the release of DBCP 1.3/1.4.
>>
>>  As previously discussed, the only difference between
>>  1.3 and 1.4 is that the 1.3 sources have been filtered to exclude
>>  JDBC4 methods.  Version 1.3 is for JDK 1.4-1.5 and only builds under
>>  one of these JDKs.  Note that to execute the 1.3 maven build under
>>  JDK 1.4 you need a 2.0.x version of maven.
>>
>>  Here are the artifacts:
>>
>>  1.3 (JDBC 3) version:
>>  http://people.apache.org/~psteitz/dbcp-1.3-rc7
>>  http://people.apache.org/~psteitz/dbcp-1.3-rc7/site
>>  http://people.apache.org/~psteitz/dbcp-1.3-rc7/maven
>>  http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC7/
>>
>>  1.4 (JDBC 4) version:
>>  http://people.apache.org/~psteitz/dbcp-1.4-rc7
>>  http://people.apache.org/~psteitz/dbcp-1.4-rc7/site
>>  http://people.apache.org/~psteitz/dbcp-1.4-rc7/maven
>>  http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC7/
>>
>>  Release notes (common version, ships with both)
>>  http://people.apache.org/~psteitz/RELEASE-NOTES.txt
>>
>>  Votes, please. This VOTE will close 10-February-2010 19:00 GMT.
>>
>>  [ ] +1 Proceed with release
> 
> +1
> 
> All looks OK; both 1.4 and 1.3 build and test OK on Win/XP.
> 
>>  [ ] +0 OK
>>  [ ] -0 OK, but I would prefer...
> 
> However, I'm not sure about the site: why does it have links to
> Javadocs for 1.2.2 and especially why a link to Javadoc for
> 1.4.1-SNAPSHOT?

The site will be correct when published post-release.  It is good
(IMO) to retain links to javadoc for the last couple releases.   I
will push the 1.2.2 release javadoc to the location in the link
post-release.

> 
> Are both sites going to be published?
> If not, the links on the front page entitled "JavaDoc API documents"
> and "org.apache.commons.dbcp" need to be adjusted to allow for both
> versions.

No, only the 1.4 version.

> 
>>  [ ] -1 No, showstopper = ...
>>
>>  Thanks!
>>
>>  Phil
>>
>>  ---------------------------------------------------------------------
>>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>  For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release DBCP 1.3/1.4 based on RC7

Posted by sebb <se...@gmail.com>.
On 07/02/2010, Phil Steitz <ph...@gmail.com> wrote:
> Having corrected the problems identified with RC6 (unit test timing
>  errors, unnecessary trivial object caches, unnecessary mutability in
>  CPDS factories, incomplete fix for DBCP-8), I would like to move
>  forward with the release of DBCP 1.3/1.4.
>
>  As previously discussed, the only difference between
>  1.3 and 1.4 is that the 1.3 sources have been filtered to exclude
>  JDBC4 methods.  Version 1.3 is for JDK 1.4-1.5 and only builds under
>  one of these JDKs.  Note that to execute the 1.3 maven build under
>  JDK 1.4 you need a 2.0.x version of maven.
>
>  Here are the artifacts:
>
>  1.3 (JDBC 3) version:
>  http://people.apache.org/~psteitz/dbcp-1.3-rc7
>  http://people.apache.org/~psteitz/dbcp-1.3-rc7/site
>  http://people.apache.org/~psteitz/dbcp-1.3-rc7/maven
>  http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC7/
>
>  1.4 (JDBC 4) version:
>  http://people.apache.org/~psteitz/dbcp-1.4-rc7
>  http://people.apache.org/~psteitz/dbcp-1.4-rc7/site
>  http://people.apache.org/~psteitz/dbcp-1.4-rc7/maven
>  http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC7/
>
>  Release notes (common version, ships with both)
>  http://people.apache.org/~psteitz/RELEASE-NOTES.txt
>
>  Votes, please. This VOTE will close 10-February-2010 19:00 GMT.
>
>  [ ] +1 Proceed with release

+1

All looks OK; both 1.4 and 1.3 build and test OK on Win/XP.

>  [ ] +0 OK
>  [ ] -0 OK, but I would prefer...

However, I'm not sure about the site: why does it have links to
Javadocs for 1.2.2 and especially why a link to Javadoc for
1.4.1-SNAPSHOT?

Are both sites going to be published?
If not, the links on the front page entitled "JavaDoc API documents"
and "org.apache.commons.dbcp" need to be adjusted to allow for both
versions.

>  [ ] -1 No, showstopper = ...
>
>  Thanks!
>
>  Phil
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>  For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release DBCP 1.3/1.4 based on RC7

Posted by Phil Steitz <ph...@gmail.com>.
Here is my +1

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release DBCP 1.3/1.4 based on RC7

Posted by Mark Thomas <ma...@apache.org>.
On 07/02/2010 18:55, Phil Steitz wrote:
> Release notes (common version, ships with both)
> http://people.apache.org/~psteitz/RELEASE-NOTES.txt
> 
> Votes, please. This VOTE will close 10-February-2010 19:00 GMT.
> 
> [X] +1 Proceed with release
> [ ] +0 OK
> [ ] -0 OK, but I would prefer...
> [ ] -1 No, showstopper = ...

src MD5s match
src SIGs match, key in WoT
src.zip matches tag (less expected exclusions)
src.tar.gz matches tag

Tests pass

Mark




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: RESULT: [ VOTE] Release DBCP 1.3/1.4 based on RC7

Posted by Phil Steitz <ph...@gmail.com>.
Jörg Schaible wrote:
> Phil Steitz wrote at Donnerstag, 11. Februar 2010 01:09:
> 
>> This vote has passed with 4 binding +1 VOTES from
>>
>> Sebastian Bazley
>> Phil Steitz
>> Oliver Heger
>> Mark Thomas
>>
>> No other votes.
>>
>> Thanks!
> 
> Add mine, I tested the src tarballs yesterday with my compiler zoo, but 
> forgot to send the vote afterwarsd ;-)
> 
> So: +1

Thanks to you and the aminals in the zoo!
And thanks for your help with the RCs...
> 
> - Jörg
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: RESULT: [ VOTE] Release DBCP 1.3/1.4 based on RC7

Posted by Jörg Schaible <jo...@gmx.de>.
Phil Steitz wrote at Donnerstag, 11. Februar 2010 01:09:

> This vote has passed with 4 binding +1 VOTES from
> 
> Sebastian Bazley
> Phil Steitz
> Oliver Heger
> Mark Thomas
> 
> No other votes.
> 
> Thanks!

Add mine, I tested the src tarballs yesterday with my compiler zoo, but 
forgot to send the vote afterwarsd ;-)

So: +1

- Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


RESULT: [ VOTE] Release DBCP 1.3/1.4 based on RC7

Posted by Phil Steitz <ph...@gmail.com>.
This vote has passed with 4 binding +1 VOTES from

Sebastian Bazley
Phil Steitz
Oliver Heger
Mark Thomas

No other votes.

Thanks!

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release DBCP 1.3/1.4 based on RC7

Posted by Oliver Heger <ol...@oliver-heger.de>.
Am 09.02.2010 14:47, schrieb Phil Steitz:
> Oliver Heger wrote:
>> Tested build successfully under Windows 7 with JDKs 1.4 and 1.5 (for
>> version 1.3) and 1.6 (for version 1.4).
>>
>> I was not able to generate the site because for both versions and all
>> JDKs it hangs after saying "[INFO] Generating "Dependencies" report.",
>> but maybe this is a local problem or it just takes very long? No
>> showstopper.
>>
>> Artifacts and sites look good.
>>
>> So +1
>>
>> Oliver
>
> Thanks, Oliver. Regarding the site build, the dependencies report
> does take a few seconds (but not that long) for both versions, but
> consistently works4me on both Linux and Mac OSX, maven 2.2.1 (JDK
> 1.6, dbcp 1.4) and maven 2.0.10 (JDK 1.5, dbcp 1.3).  What versions
> of maven did you use to test?

Version 2.0.10.

Oliver

>
> Phil
>>
>> Am 07.02.2010 19:55, schrieb Phil Steitz:
>>> Having corrected the problems identified with RC6 (unit test timing
>>> errors, unnecessary trivial object caches, unnecessary mutability in
>>> CPDS factories, incomplete fix for DBCP-8), I would like to move
>>> forward with the release of DBCP 1.3/1.4.
>>>
>>> As previously discussed, the only difference between
>>> 1.3 and 1.4 is that the 1.3 sources have been filtered to exclude
>>> JDBC4 methods.  Version 1.3 is for JDK 1.4-1.5 and only builds under
>>> one of these JDKs.  Note that to execute the 1.3 maven build under
>>> JDK 1.4 you need a 2.0.x version of maven.
>>>
>>> Here are the artifacts:
>>>
>>> 1.3 (JDBC 3) version:
>>> http://people.apache.org/~psteitz/dbcp-1.3-rc7
>>> http://people.apache.org/~psteitz/dbcp-1.3-rc7/site
>>> http://people.apache.org/~psteitz/dbcp-1.3-rc7/maven
>>> http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC7/
>>>
>>> 1.4 (JDBC 4) version:
>>> http://people.apache.org/~psteitz/dbcp-1.4-rc7
>>> http://people.apache.org/~psteitz/dbcp-1.4-rc7/site
>>> http://people.apache.org/~psteitz/dbcp-1.4-rc7/maven
>>> http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC7/
>>>
>>> Release notes (common version, ships with both)
>>> http://people.apache.org/~psteitz/RELEASE-NOTES.txt
>>>
>>> Votes, please. This VOTE will close 10-February-2010 19:00 GMT.
>>>
>>> [ ] +1 Proceed with release
>>> [ ] +0 OK
>>> [ ] -0 OK, but I would prefer...
>>> [ ] -1 No, showstopper = ...
>>>
>>> Thanks!
>>>
>>> Phil
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release DBCP 1.3/1.4 based on RC7

Posted by Phil Steitz <ph...@gmail.com>.
Oliver Heger wrote:
> Tested build successfully under Windows 7 with JDKs 1.4 and 1.5 (for
> version 1.3) and 1.6 (for version 1.4).
> 
> I was not able to generate the site because for both versions and all
> JDKs it hangs after saying "[INFO] Generating "Dependencies" report.",
> but maybe this is a local problem or it just takes very long? No
> showstopper.
> 
> Artifacts and sites look good.
> 
> So +1
> 
> Oliver

Thanks, Oliver. Regarding the site build, the dependencies report
does take a few seconds (but not that long) for both versions, but
consistently works4me on both Linux and Mac OSX, maven 2.2.1 (JDK
1.6, dbcp 1.4) and maven 2.0.10 (JDK 1.5, dbcp 1.3).  What versions
of maven did you use to test?

Phil
> 
> Am 07.02.2010 19:55, schrieb Phil Steitz:
>> Having corrected the problems identified with RC6 (unit test timing
>> errors, unnecessary trivial object caches, unnecessary mutability in
>> CPDS factories, incomplete fix for DBCP-8), I would like to move
>> forward with the release of DBCP 1.3/1.4.
>>
>> As previously discussed, the only difference between
>> 1.3 and 1.4 is that the 1.3 sources have been filtered to exclude
>> JDBC4 methods.  Version 1.3 is for JDK 1.4-1.5 and only builds under
>> one of these JDKs.  Note that to execute the 1.3 maven build under
>> JDK 1.4 you need a 2.0.x version of maven.
>>
>> Here are the artifacts:
>>
>> 1.3 (JDBC 3) version:
>> http://people.apache.org/~psteitz/dbcp-1.3-rc7
>> http://people.apache.org/~psteitz/dbcp-1.3-rc7/site
>> http://people.apache.org/~psteitz/dbcp-1.3-rc7/maven
>> http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC7/
>>
>> 1.4 (JDBC 4) version:
>> http://people.apache.org/~psteitz/dbcp-1.4-rc7
>> http://people.apache.org/~psteitz/dbcp-1.4-rc7/site
>> http://people.apache.org/~psteitz/dbcp-1.4-rc7/maven
>> http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC7/
>>
>> Release notes (common version, ships with both)
>> http://people.apache.org/~psteitz/RELEASE-NOTES.txt
>>
>> Votes, please. This VOTE will close 10-February-2010 19:00 GMT.
>>
>> [ ] +1 Proceed with release
>> [ ] +0 OK
>> [ ] -0 OK, but I would prefer...
>> [ ] -1 No, showstopper = ...
>>
>> Thanks!
>>
>> Phil
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release DBCP 1.3/1.4 based on RC7

Posted by Oliver Heger <ol...@oliver-heger.de>.
Tested build successfully under Windows 7 with JDKs 1.4 and 1.5 (for 
version 1.3) and 1.6 (for version 1.4).

I was not able to generate the site because for both versions and all 
JDKs it hangs after saying "[INFO] Generating "Dependencies" report.", 
but maybe this is a local problem or it just takes very long? No 
showstopper.

Artifacts and sites look good.

So +1

Oliver

Am 07.02.2010 19:55, schrieb Phil Steitz:
> Having corrected the problems identified with RC6 (unit test timing
> errors, unnecessary trivial object caches, unnecessary mutability in
> CPDS factories, incomplete fix for DBCP-8), I would like to move
> forward with the release of DBCP 1.3/1.4.
>
> As previously discussed, the only difference between
> 1.3 and 1.4 is that the 1.3 sources have been filtered to exclude
> JDBC4 methods.  Version 1.3 is for JDK 1.4-1.5 and only builds under
> one of these JDKs.  Note that to execute the 1.3 maven build under
> JDK 1.4 you need a 2.0.x version of maven.
>
> Here are the artifacts:
>
> 1.3 (JDBC 3) version:
> http://people.apache.org/~psteitz/dbcp-1.3-rc7
> http://people.apache.org/~psteitz/dbcp-1.3-rc7/site
> http://people.apache.org/~psteitz/dbcp-1.3-rc7/maven
> http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC7/
>
> 1.4 (JDBC 4) version:
> http://people.apache.org/~psteitz/dbcp-1.4-rc7
> http://people.apache.org/~psteitz/dbcp-1.4-rc7/site
> http://people.apache.org/~psteitz/dbcp-1.4-rc7/maven
> http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC7/
>
> Release notes (common version, ships with both)
> http://people.apache.org/~psteitz/RELEASE-NOTES.txt
>
> Votes, please. This VOTE will close 10-February-2010 19:00 GMT.
>
> [ ] +1 Proceed with release
> [ ] +0 OK
> [ ] -0 OK, but I would prefer...
> [ ] -1 No, showstopper = ...
>
> Thanks!
>
> Phil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org