You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Brian Hulette (Jira)" <ji...@apache.org> on 2021/09/24 22:22:00 UTC
[jira] [Commented] (BEAM-11831) Remove duplicated Spanner client
configuration
[ https://issues.apache.org/jira/browse/BEAM-11831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17420005#comment-17420005 ]
Brian Hulette commented on BEAM-11831:
--------------------------------------
./gradlew sdks:java:io:google-cloud-platform:dependencyReport shows:
{code}
+--- com.google.cloud:libraries-bom:22.0.0
...
| +--- com.google.cloud:google-cloud-spanner:6.12.1 (c)
{code}
So we should be fine to drop the duplicated code now.
> Remove duplicated Spanner client configuration
> ----------------------------------------------
>
> Key: BEAM-11831
> URL: https://issues.apache.org/jira/browse/BEAM-11831
> Project: Beam
> Issue Type: Task
> Components: io-java-gcp
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P3
>
> The resolution for BEAM-11805 was to duplicate the default values from the Spanner client, and then modify them to include the updated spanner agent.
> Once there's a GCP bom release with a spanner client that fixes https://github.com/googleapis/java-spanner/pull/871 (4.0.0 release has it: https://github.com/googleapis/java-spanner/releases/tag/v4.0.0), we should upgrade to the new client and remove the duplicated code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)