You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Anne Yu <an...@cloudera.com> on 2016/07/29 17:27:43 UTC
Review Request 50611: Sentry HA Test: programmatic failover,
validate privileges before and afterwards.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50611/
-----------------------------------------------------------
Review request for sentry, Hao Hao and Sravya Tirukkovalur.
Bugs: SENTRY-1423
https://issues.apache.org/jira/browse/SENTRY-1423
Repository: sentry
Description
-------
Sentry HA Test: test programmatic failover, validate privileges before and afterwards. validate expected exception is thrown.
Diffs
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 7dc3d0f30583b9edd16015218b199e298d192e8c
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java 054b1935975368db058791102f3892f027e31636
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/SentrySrv.java dac11517f36a743dff8730465fbf2397ebf16c88
Diff: https://reviews.apache.org/r/50611/diff/
Testing
-------
Thanks,
Anne Yu
Re: Review Request 50611: Sentry HA Test: programmatic failover,
validate privileges before and afterwards.
Posted by Anne Yu <an...@cloudera.com>.
> On July 29, 2016, 6:26 p.m., Rahul Sharma wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java, lines 117-120
> > <https://reviews.apache.org/r/50611/diff/1/?file=1457990#file1457990line117>
> >
> > how is the boolean return value from failover() useful?
Yeah, will validate this boolean value before move forward to validation.
> On July 29, 2016, 6:26 p.m., Rahul Sharma wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java, line 36
> > <https://reviews.apache.org/r/50611/diff/1/?file=1457991#file1457991line36>
> >
> > Logger for this class?
Good catch, will modify this to the current class.
- Anne
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50611/#review144144
-----------------------------------------------------------
On July 29, 2016, 5:27 p.m., Anne Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50611/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 5:27 p.m.)
>
>
> Review request for sentry, Hao Hao and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-1423
> https://issues.apache.org/jira/browse/SENTRY-1423
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry HA Test: test programmatic failover, validate privileges before and afterwards. validate expected exception is thrown.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 7dc3d0f30583b9edd16015218b199e298d192e8c
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java 054b1935975368db058791102f3892f027e31636
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/SentrySrv.java dac11517f36a743dff8730465fbf2397ebf16c88
>
> Diff: https://reviews.apache.org/r/50611/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anne Yu
>
>
Re: Review Request 50611: Sentry HA Test: programmatic failover,
validate privileges before and afterwards.
Posted by Rahul Sharma <ra...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50611/#review144144
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java (lines 117 - 120)
<https://reviews.apache.org/r/50611/#comment210159>
how is the boolean return value from failover() useful?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java (line 36)
<https://reviews.apache.org/r/50611/#comment210158>
Logger for this class?
- Rahul Sharma
On July 29, 2016, 5:27 p.m., Anne Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50611/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 5:27 p.m.)
>
>
> Review request for sentry, Hao Hao and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-1423
> https://issues.apache.org/jira/browse/SENTRY-1423
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry HA Test: test programmatic failover, validate privileges before and afterwards. validate expected exception is thrown.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 7dc3d0f30583b9edd16015218b199e298d192e8c
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java 054b1935975368db058791102f3892f027e31636
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/SentrySrv.java dac11517f36a743dff8730465fbf2397ebf16c88
>
> Diff: https://reviews.apache.org/r/50611/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anne Yu
>
>
Re: Review Request 50611: Sentry HA Test: programmatic failover,
validate privileges before and afterwards.
Posted by Anne Yu <an...@cloudera.com>.
> On Aug. 17, 2016, 2:48 a.m., Dapeng Sun wrote:
> > Thank Anne for your patch, I left some minor comments.
Thanks Dapeng.
> On Aug. 17, 2016, 2:48 a.m., Dapeng Sun wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java, line 114
> > <https://reviews.apache.org/r/50611/diff/3/?file=1475619#file1475619line114>
> >
> > Nit: seem it is isActive's opposite, could we remove it to keep the code clean?
Yeah, maybe just wrap around isActive.
> On Aug. 17, 2016, 2:48 a.m., Dapeng Sun wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java, line 200
> > <https://reviews.apache.org/r/50611/diff/3/?file=1475619#file1475619line200>
> >
> > Nit: Just curious about why externalSentryService is related to Kerberos keytab file
If the cluster is managed by an external software such as CDH, the keytab file is pre-installed, not managed by test. So from outside, we will need to pass keytab file location. One qq here, in mini-cluster testing environment (internal server), does it also use keytab and kerberos file?
> On Aug. 17, 2016, 2:48 a.m., Dapeng Sun wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java, line 254
> > <https://reviews.apache.org/r/50611/diff/3/?file=1475619#file1475619line254>
> >
> > Nit: Better to add try catch block here.
Will do so.
- Anne
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50611/#review145951
-----------------------------------------------------------
On Aug. 16, 2016, 6:17 p.m., Anne Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50611/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2016, 6:17 p.m.)
>
>
> Review request for sentry, Hao Hao and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-1423
> https://issues.apache.org/jira/browse/SENTRY-1423
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry HA Test: test programmatic failover, validate privileges before and afterwards. validate expected exception is thrown.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java 56d774b883914dbffff438101f47fb94518c94d5
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 7dc3d0f30583b9edd16015218b199e298d192e8c
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java 3f57a003903961a6aea98bd583a14b65bd2b98a2
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java 054b1935975368db058791102f3892f027e31636
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/SentrySrv.java dac11517f36a743dff8730465fbf2397ebf16c88
>
> Diff: https://reviews.apache.org/r/50611/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anne Yu
>
>
Re: Review Request 50611: Sentry HA Test: programmatic failover,
validate privileges before and afterwards.
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50611/#review145951
-----------------------------------------------------------
Thank Anne for your patch, I left some minor comments.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java (line 114)
<https://reviews.apache.org/r/50611/#comment212307>
Nit: seem it is isActive's opposite, could we remove it to keep the code clean?
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java (line 200)
<https://reviews.apache.org/r/50611/#comment212308>
Nit: Just curious about why externalSentryService is related to Kerberos keytab file
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java (line 254)
<https://reviews.apache.org/r/50611/#comment212309>
Nit: Better to add try catch block here.
- Dapeng Sun
On \u516b\u6708 17, 2016, 2:17 a.m., Anne Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50611/
> -----------------------------------------------------------
>
> (Updated \u516b\u6708 17, 2016, 2:17 a.m.)
>
>
> Review request for sentry, Hao Hao and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-1423
> https://issues.apache.org/jira/browse/SENTRY-1423
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry HA Test: test programmatic failover, validate privileges before and afterwards. validate expected exception is thrown.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java 56d774b883914dbffff438101f47fb94518c94d5
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 7dc3d0f30583b9edd16015218b199e298d192e8c
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java 3f57a003903961a6aea98bd583a14b65bd2b98a2
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java 054b1935975368db058791102f3892f027e31636
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/SentrySrv.java dac11517f36a743dff8730465fbf2397ebf16c88
>
> Diff: https://reviews.apache.org/r/50611/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anne Yu
>
>
Re: Review Request 50611: Sentry HA Test: programmatic failover,
validate privileges before and afterwards.
Posted by Anne Yu <an...@cloudera.com>.
> On Aug. 18, 2016, 2:29 a.m., Dapeng Sun wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java, line 200
> > <https://reviews.apache.org/r/50611/diff/3/?file=1475619#file1475619line200>
> >
> > >>One qq here, in mini-cluster testing environment (internal server), does it also use keytab and kerberos file?
> >
> > In mini-cluster, I think there is no kerberos at e2e. In some UT, we use keytab to login and get the credential.
> >
> > Do you mean the exception is used for avoiding the method is called at external SentryService case?
I meant to ask to test sentry client in UT, need to consider kerberos authentication or not. Maybe not necessary since I don't see it gets configured in AbstractTestWithStaticConfiguration.
- Anne
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50611/#review146061
-----------------------------------------------------------
On Aug. 16, 2016, 6:17 p.m., Anne Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50611/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2016, 6:17 p.m.)
>
>
> Review request for sentry, Hao Hao and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-1423
> https://issues.apache.org/jira/browse/SENTRY-1423
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry HA Test: test programmatic failover, validate privileges before and afterwards. validate expected exception is thrown.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java 56d774b883914dbffff438101f47fb94518c94d5
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 7dc3d0f30583b9edd16015218b199e298d192e8c
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java 3f57a003903961a6aea98bd583a14b65bd2b98a2
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java 054b1935975368db058791102f3892f027e31636
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/SentrySrv.java dac11517f36a743dff8730465fbf2397ebf16c88
>
> Diff: https://reviews.apache.org/r/50611/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anne Yu
>
>
Re: Review Request 50611: Sentry HA Test: programmatic failover,
validate privileges before and afterwards.
Posted by Dapeng Sun <da...@intel.com>.
> On \u516b\u6708 18, 2016, 10:29 a.m., Dapeng Sun wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java, line 200
> > <https://reviews.apache.org/r/50611/diff/3/?file=1475619#file1475619line200>
> >
> > >>One qq here, in mini-cluster testing environment (internal server), does it also use keytab and kerberos file?
> >
> > In mini-cluster, I think there is no kerberos at e2e. In some UT, we use keytab to login and get the credential.
> >
> > Do you mean the exception is used for avoiding the method is called at external SentryService case?
>
> Anne Yu wrote:
> I meant to ask to test sentry client in UT, need to consider kerberos authentication or not. Maybe not necessary since I don't see it gets configured in AbstractTestWithStaticConfiguration.
>> Maybe not necessary since I don't see it gets configured in AbstractTestWithStaticConfiguration.
I'm agreed with you.
- Dapeng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50611/#review146061
-----------------------------------------------------------
On \u516b\u6708 17, 2016, 2:17 a.m., Anne Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50611/
> -----------------------------------------------------------
>
> (Updated \u516b\u6708 17, 2016, 2:17 a.m.)
>
>
> Review request for sentry, Hao Hao and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-1423
> https://issues.apache.org/jira/browse/SENTRY-1423
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry HA Test: test programmatic failover, validate privileges before and afterwards. validate expected exception is thrown.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java 56d774b883914dbffff438101f47fb94518c94d5
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 7dc3d0f30583b9edd16015218b199e298d192e8c
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java 3f57a003903961a6aea98bd583a14b65bd2b98a2
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java 054b1935975368db058791102f3892f027e31636
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/SentrySrv.java dac11517f36a743dff8730465fbf2397ebf16c88
>
> Diff: https://reviews.apache.org/r/50611/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anne Yu
>
>
Re: Review Request 50611: Sentry HA Test: programmatic failover,
validate privileges before and afterwards.
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50611/#review146061
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java (line 200)
<https://reviews.apache.org/r/50611/#comment212439>
>>One qq here, in mini-cluster testing environment (internal server), does it also use keytab and kerberos file?
In mini-cluster, I think there is no kerberos at e2e. In some UT, we use keytab to login and get the credential.
Do you mean the exception is used for avoiding the method is called at external SentryService case?
- Dapeng Sun
On \u516b\u6708 17, 2016, 2:17 a.m., Anne Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50611/
> -----------------------------------------------------------
>
> (Updated \u516b\u6708 17, 2016, 2:17 a.m.)
>
>
> Review request for sentry, Hao Hao and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-1423
> https://issues.apache.org/jira/browse/SENTRY-1423
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry HA Test: test programmatic failover, validate privileges before and afterwards. validate expected exception is thrown.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java 56d774b883914dbffff438101f47fb94518c94d5
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 7dc3d0f30583b9edd16015218b199e298d192e8c
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java 3f57a003903961a6aea98bd583a14b65bd2b98a2
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java 054b1935975368db058791102f3892f027e31636
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/SentrySrv.java dac11517f36a743dff8730465fbf2397ebf16c88
>
> Diff: https://reviews.apache.org/r/50611/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anne Yu
>
>
Re: Review Request 50611: Sentry HA Test: programmatic failover,
validate privileges before and afterwards.
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50611/#review146165
-----------------------------------------------------------
Thank Anne, I have no more question.
- Dapeng Sun
On \u516b\u6708 17, 2016, 2:17 a.m., Anne Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50611/
> -----------------------------------------------------------
>
> (Updated \u516b\u6708 17, 2016, 2:17 a.m.)
>
>
> Review request for sentry, Hao Hao and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-1423
> https://issues.apache.org/jira/browse/SENTRY-1423
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Sentry HA Test: test programmatic failover, validate privileges before and afterwards. validate expected exception is thrown.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java 56d774b883914dbffff438101f47fb94518c94d5
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 7dc3d0f30583b9edd16015218b199e298d192e8c
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java 3f57a003903961a6aea98bd583a14b65bd2b98a2
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java 054b1935975368db058791102f3892f027e31636
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/SentrySrv.java dac11517f36a743dff8730465fbf2397ebf16c88
>
> Diff: https://reviews.apache.org/r/50611/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anne Yu
>
>
Re: Review Request 50611: Sentry HA Test: programmatic failover,
validate privileges before and afterwards.
Posted by Anne Yu <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50611/
-----------------------------------------------------------
(Updated Aug. 16, 2016, 6:17 p.m.)
Review request for sentry, Hao Hao and Sravya Tirukkovalur.
Changes
-------
Addressed previous comments;
Also updated a couple of files to test sentry ha and pool based clients.
Bugs: SENTRY-1423
https://issues.apache.org/jira/browse/SENTRY-1423
Repository: sentry
Description
-------
Sentry HA Test: test programmatic failover, validate privileges before and afterwards. validate expected exception is thrown.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java 56d774b883914dbffff438101f47fb94518c94d5
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 7dc3d0f30583b9edd16015218b199e298d192e8c
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java 3f57a003903961a6aea98bd583a14b65bd2b98a2
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java 054b1935975368db058791102f3892f027e31636
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/SentrySrv.java dac11517f36a743dff8730465fbf2397ebf16c88
Diff: https://reviews.apache.org/r/50611/diff/
Testing
-------
Thanks,
Anne Yu
Re: Review Request 50611: Sentry HA Test: programmatic failover,
validate privileges before and afterwards.
Posted by Anne Yu <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50611/
-----------------------------------------------------------
(Updated July 29, 2016, 8:03 p.m.)
Review request for sentry, Hao Hao and Sravya Tirukkovalur.
Changes
-------
1. addressed Rahul's comments;
2. enable sentry client pool for testing;
3. ensure can parse external test configurations and internally specified test values.
Bugs: SENTRY-1423
https://issues.apache.org/jira/browse/SENTRY-1423
Repository: sentry
Description
-------
Sentry HA Test: test programmatic failover, validate privileges before and afterwards. validate expected exception is thrown.
Diffs (updated)
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestProgrammaticFailover.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestSentryHABase.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 7dc3d0f30583b9edd16015218b199e298d192e8c
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java 054b1935975368db058791102f3892f027e31636
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/SentrySrv.java dac11517f36a743dff8730465fbf2397ebf16c88
Diff: https://reviews.apache.org/r/50611/diff/
Testing
-------
Thanks,
Anne Yu