You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/14 02:58:29 UTC

[GitHub] [iceberg] jinchengchenghh opened a new issue #2821: Can we use table property for spark Actions.expireOlderThan retention default value

jinchengchenghh opened a new issue #2821:
URL: https://github.com/apache/iceberg/issues/2821


   I find this PR set the table property as default snapshots retention, but only used for RemoveSnapshots
   
   `public static final String MAX_SNAPSHOT_AGE_MS = "history.expire.max-snapshot-age-ms";`
   `public static final long MAX_SNAPSHOT_AGE_MS_DEFAULT = 5 * 24 * 60 * 60 * 1000; // 5 days`
   
   Maybe this default value can also used for Actions.forTable(table).expireSnapshots().expireOlderThan(end)
   
   while
   `end = System.currentTimeMillis() - maxSnapshotAgeMs`
   
   @aokolnychyi 
   #1868


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] RussellSpitzer commented on issue #2821: Can we use table property MAX_SNAPSHOT_AGE_MS for spark Actions snapshot retention default value

Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on issue #2821:
URL: https://github.com/apache/iceberg/issues/2821#issuecomment-879902726


   Expire snapshots action uses remove snapshots under the hood to actually do the snapshot expiration so I think this should work right now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] jinchengchenghh commented on issue #2821: Can we use table property MAX_SNAPSHOT_AGE_MS for spark Actions snapshot retention default value

Posted by GitBox <gi...@apache.org>.
jinchengchenghh commented on issue #2821:
URL: https://github.com/apache/iceberg/issues/2821#issuecomment-880338245


   Thanks you for your reply. I misunderstand, it has worked now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] jinchengchenghh closed issue #2821: Can we use table property MAX_SNAPSHOT_AGE_MS for spark Actions snapshot retention default value

Posted by GitBox <gi...@apache.org>.
jinchengchenghh closed issue #2821:
URL: https://github.com/apache/iceberg/issues/2821


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org