You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/09/16 13:25:47 UTC
[GitHub] [incubator-doris] zenoyang opened a new pull request #6687: [Bug] Cache cannot sense the modification of the view
zenoyang opened a new pull request #6687:
URL: https://github.com/apache/incubator-doris/pull/6687
## Proposed changes
Modifying the view is equivalent to modifying the sql, but because the sql string has not changed, the query will hit the cached result before the view is modified.
Fix the bug that the cache cannot perceive view modification:
- When modifying the view, update createTime
- Use `originalSql + latestViewUpdateTime` as the input of the md5 function to generate a sql_key
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinghuayu007 commented on pull request #6687: [Bug] Cache cannot sense the modification of the view
Posted by GitBox <gi...@apache.org>.
xinghuayu007 commented on pull request #6687:
URL: https://github.com/apache/incubator-doris/pull/6687#issuecomment-925543123
`VIEW` is actually a SQL. Modifying VIEW means modifying the SQL. A query on VIEW will be parsed into a new SQL where view table is replace with view_sql. If it is easy to generate the final SQL, it will be better to take final SQL as the cache key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zenoyang closed pull request #6687: [Bug] Cache cannot sense the modification of the view
Posted by GitBox <gi...@apache.org>.
zenoyang closed pull request #6687:
URL: https://github.com/apache/incubator-doris/pull/6687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zenoyang commented on pull request #6687: [Bug] Cache cannot sense the modification of the view
Posted by GitBox <gi...@apache.org>.
zenoyang commented on pull request #6687:
URL: https://github.com/apache/incubator-doris/pull/6687#issuecomment-926315383
> `VIEW` is actually a SQL. Modifying VIEW means modifying the SQL. A query on VIEW will be parsed into a new SQL where view table is replace with view_sql. If it is easy to generate the final SQL, it will be better to take final SQL as the cache key.
hi, I submitted a new PR to solve this problem. Please review again，PR: #6736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org