You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/06/22 19:09:17 UTC
Review Request 60374: Required that resources are always downgraded
for a non-capable agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60374/
-----------------------------------------------------------
Review request for mesos and Neil Conway.
Repository: mesos
Description
-------
Since the master prevents refined reservations from being created on
non-capable agents, we cannot be in a situation in which the resources
are not downgradable for a non-capable agent.
Diffs
-----
src/master/master.cpp ec594a8f4fa95e77fc38103c5561d1797fe2b133
Diff: https://reviews.apache.org/r/60374/diff/1/
Testing
-------
Thanks,
Michael Park
Re: Review Request 60374: Required that resources are always
downgraded for a non-capable agent.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60374/#review178743
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On June 22, 2017, 7:09 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60374/
> -----------------------------------------------------------
>
> (Updated June 22, 2017, 7:09 p.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Bugs: MESOS-7575
> https://issues.apache.org/jira/browse/MESOS-7575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the master prevents refined reservations from being created on
> non-capable agents, we cannot be in a situation in which the resources
> are not downgradable for a non-capable agent.
>
>
> Diffs
> -----
>
> src/master/master.cpp b0818e1e59ce9804cd9592aa2a7ec8f80ba5bddf
>
>
> Diff: https://reviews.apache.org/r/60374/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 60374: Required that resources are always
downgraded for a non-capable agent.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60374/#review178737
-----------------------------------------------------------
src/master/master.cpp
Line 4919 (original), 4907 (patched)
<https://reviews.apache.org/r/60374/#comment252897>
Can we add a comment explaining why these are `CHECK`s?
- Neil Conway
On June 22, 2017, 7:09 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60374/
> -----------------------------------------------------------
>
> (Updated June 22, 2017, 7:09 p.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Bugs: MESOS-7575
> https://issues.apache.org/jira/browse/MESOS-7575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the master prevents refined reservations from being created on
> non-capable agents, we cannot be in a situation in which the resources
> are not downgradable for a non-capable agent.
>
>
> Diffs
> -----
>
> src/master/master.cpp ec594a8f4fa95e77fc38103c5561d1797fe2b133
>
>
> Diff: https://reviews.apache.org/r/60374/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 60374: Required that resources are always
downgraded for a non-capable agent.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60374/#review178733
-----------------------------------------------------------
Patch looks great!
Reviews applied: [60281, 60282, 60351, 60352, 60283, 60255, 60284, 60374]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On June 22, 2017, 7:09 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60374/
> -----------------------------------------------------------
>
> (Updated June 22, 2017, 7:09 p.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Bugs: MESOS-7575
> https://issues.apache.org/jira/browse/MESOS-7575
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the master prevents refined reservations from being created on
> non-capable agents, we cannot be in a situation in which the resources
> are not downgradable for a non-capable agent.
>
>
> Diffs
> -----
>
> src/master/master.cpp ec594a8f4fa95e77fc38103c5561d1797fe2b133
>
>
> Diff: https://reviews.apache.org/r/60374/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>