You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2024/09/12 17:47:40 UTC

[kudu-CR](branch-1.17.x) KUDU-3590 Update expired test certificates

Hello Marton Greber, Zoltan Chovan,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/21795

to review the following change.


Change subject: KUDU-3590 Update expired test certificates
......................................................................

KUDU-3590 Update expired test certificates

Certificates generated in 2d624f877 expired after 1 year, causing
several test failures in security-itest and rpc-test.

This commit replaces the expired certificates with ones with a validity
of 20 years.

Note: If you git blame this file in 2044 in your flying car, please make
sure to update the keys and certificates to whatever is reasonable for
your quantum computers instead of simply relying on the instructions in
the comments.

Certificate chain:

        Issuer: CN=IntermediateCA, ST=California, C=US, emailAddress=dev@kudu.apache.org, O=Apache Software Foundation, OU=Intermediate CA
        Validity
            Not Before: Jul 23 19:58:19 2024 GMT
            Not After : Apr  9 19:58:19 2044 GMT
        Subject: CN=127.0.0.1, ST=California, C=US,
        emailAddress=dev@kudu.apache.org, O=Apache Software Foundation,
        OU=Kudu

        Issuer: C=US, ST=Some-State, O=Apache Software Foundation, CN=127.0.0.1, emailAddress=dev@kudu.apache.org
        Validity
            Not Before: Jul 23 19:55:34 2024 GMT
            Not After : Jul 18 19:55:34 2044 GMT
        Subject: CN=IntermediateCA, ST=California, C=US, emailAddress=dev@kudu.apache.org, O=Apache Software Foundation, OU=Intermediate CA

        Issuer: C=US, ST=Some-State, O=Apache Software Foundation, CN=127.0.0.1, emailAddress=dev@kudu.apache.org
        Validity
            Not Before: Jul 23 17:50:11 2024 GMT
            Not After : Jun 29 17:50:11 2124 GMT
        Subject: C=US, ST=Some-State, O=Apache Software Foundation, CN=127.0.0.1, emailAddress=dev@kudu.apache.org

Change-Id: I0d9a38926307618b81e292074732d35520e9a8e9
Reviewed-on: http://gerrit.cloudera.org:8080/21607
Reviewed-by: Marton Greber <gr...@gmail.com>
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
(cherry picked from commit 4decbbdf553ed54796ddbbb49e1142925657110f)
---
M src/kudu/security/test/test_certs.cc
1 file changed, 662 insertions(+), 653 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/21795/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d9a38926307618b81e292074732d35520e9a8e9
Gerrit-Change-Number: 21795
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR](branch-1.17.x) KUDU-3590 Update expired test certificates

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21795 )

Change subject: KUDU-3590 Update expired test certificates
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/507/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d9a38926307618b81e292074732d35520e9a8e9
Gerrit-Change-Number: 21795
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Sep 2024 20:25:00 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) KUDU-3590 Update expired test certificates

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21795 )

Change subject: KUDU-3590 Update expired test certificates
......................................................................

KUDU-3590 Update expired test certificates

Certificates generated in 2d624f877 expired after 1 year, causing
several test failures in security-itest and rpc-test.

This commit replaces the expired certificates with ones with a validity
of 20 years.

Note: If you git blame this file in 2044 in your flying car, please make
sure to update the keys and certificates to whatever is reasonable for
your quantum computers instead of simply relying on the instructions in
the comments.

Certificate chain:

        Issuer: CN=IntermediateCA, ST=California, C=US, emailAddress=dev@kudu.apache.org, O=Apache Software Foundation, OU=Intermediate CA
        Validity
            Not Before: Jul 23 19:58:19 2024 GMT
            Not After : Apr  9 19:58:19 2044 GMT
        Subject: CN=127.0.0.1, ST=California, C=US,
        emailAddress=dev@kudu.apache.org, O=Apache Software Foundation,
        OU=Kudu

        Issuer: C=US, ST=Some-State, O=Apache Software Foundation, CN=127.0.0.1, emailAddress=dev@kudu.apache.org
        Validity
            Not Before: Jul 23 19:55:34 2024 GMT
            Not After : Jul 18 19:55:34 2044 GMT
        Subject: CN=IntermediateCA, ST=California, C=US, emailAddress=dev@kudu.apache.org, O=Apache Software Foundation, OU=Intermediate CA

        Issuer: C=US, ST=Some-State, O=Apache Software Foundation, CN=127.0.0.1, emailAddress=dev@kudu.apache.org
        Validity
            Not Before: Jul 23 17:50:11 2024 GMT
            Not After : Jun 29 17:50:11 2124 GMT
        Subject: C=US, ST=Some-State, O=Apache Software Foundation, CN=127.0.0.1, emailAddress=dev@kudu.apache.org

Change-Id: I0d9a38926307618b81e292074732d35520e9a8e9
Reviewed-on: http://gerrit.cloudera.org:8080/21607
Reviewed-by: Marton Greber <gr...@gmail.com>
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
(cherry picked from commit 4decbbdf553ed54796ddbbb49e1142925657110f)
Reviewed-on: http://gerrit.cloudera.org:8080/21795
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/security/test/test_certs.cc
1 file changed, 662 insertions(+), 653 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Abhishek Chennaka: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d9a38926307618b81e292074732d35520e9a8e9
Gerrit-Change-Number: 21795
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR](branch-1.17.x) KUDU-3590 Update expired test certificates

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21795 )

Change subject: KUDU-3590 Update expired test certificates
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d9a38926307618b81e292074732d35520e9a8e9
Gerrit-Change-Number: 21795
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Sep 2024 18:43:26 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) KUDU-3590 Update expired test certificates

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21795 )

Change subject: KUDU-3590 Update expired test certificates
......................................................................


Patch Set 1: Verified+1

Known test failures from TSAN build:
org.apache.kudu.client.TestSecurity


-- 
To view, visit http://gerrit.cloudera.org:8080/21795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d9a38926307618b81e292074732d35520e9a8e9
Gerrit-Change-Number: 21795
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Sep 2024 21:41:24 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) KUDU-3590 Update expired test certificates

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21795 )

Change subject: KUDU-3590 Update expired test certificates
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/507/


-- 
To view, visit http://gerrit.cloudera.org:8080/21795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d9a38926307618b81e292074732d35520e9a8e9
Gerrit-Change-Number: 21795
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Sep 2024 17:47:49 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) KUDU-3590 Update expired test certificates

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has removed a vote on this change.

Change subject: KUDU-3590 Update expired test certificates
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/21795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I0d9a38926307618b81e292074732d35520e9a8e9
Gerrit-Change-Number: 21795
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>