You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2017/05/12 23:41:07 UTC
[kudu-CR] [java client] removes duplicate checks at KuduScanToken
Hao Hao has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6882
Change subject: [java client] removes duplicate checks at KuduScanToken
......................................................................
[java client] removes duplicate checks at KuduScanToken
KUDU-579 added fault tolerant scanner support at java
client. However,it missed TODO for KUDU-1040 and results
in duplicate code at KuduScanToken. This patch removes it.
Change-Id: I7e036d5fe333009a74294d27c54fe846cdc404e9
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/6882/1
--
To view, visit http://gerrit.cloudera.org:8080/6882
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e036d5fe333009a74294d27c54fe846cdc404e9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] [java client] removes duplicate checks at KuduScanToken
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [java client] removes duplicate checks at KuduScanToken
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6882
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e036d5fe333009a74294d27c54fe846cdc404e9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [java client] removes duplicate checks at KuduScanToken
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: [java client] removes duplicate checks at KuduScanToken
......................................................................
[java client] removes duplicate checks at KuduScanToken
KUDU-579 added fault tolerant scanner support at java
client. However,it missed TODO for KUDU-1040 and results
in duplicate code at KuduScanToken. This patch removes it.
Change-Id: I7e036d5fe333009a74294d27c54fe846cdc404e9
Reviewed-on: http://gerrit.cloudera.org:8080/6882
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6882
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e036d5fe333009a74294d27c54fe846cdc404e9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>