You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/10/18 13:54:03 UTC
Re: Review Request 61947: Implemented handling of resource provider
offer operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61947/
-----------------------------------------------------------
(Updated Oct. 18, 2017, 3:54 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Rebased on top of #63001.
Bugs: MESOS-7594
https://issues.apache.org/jira/browse/MESOS-7594
Repository: mesos
Description
-------
While the resource provider manager is responsible to apply offer
operations by sending events to the respective resource providers,
the master takes care of accepting these operations. Hence, for local
resource providers the master sends an `ApplyResourceOperationMessage`
to the agent where the resource provider is running on. The agent
then relays the operation contained in the message to the resource
provider manager.
Diffs (updated)
-----
src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
src/slave/slave.hpp aea1e948209c7c8945665915bc2f6d8eb47814ef
src/slave/slave.cpp 4d7dc8e9a3901b00103031e24e5d6328d0f2e2ad
Diff: https://reviews.apache.org/r/61947/diff/3/
Changes: https://reviews.apache.org/r/61947/diff/2-3/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 61947: Implemented handling of resource provider
offer operations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61947/
-----------------------------------------------------------
(Updated Oct. 20, 2017, 2:54 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Rebased, addressed issues: No longer alters `slave->totalResources` by calling `apply`.
Bugs: MESOS-7594
https://issues.apache.org/jira/browse/MESOS-7594
Repository: mesos
Description
-------
While the resource provider manager is responsible to apply offer
operations by sending events to the respective resource providers,
the master takes care of accepting these operations. Hence, for local
resource providers the master sends an `ApplyResourceOperationMessage`
to the agent where the resource provider is running on. The agent
then relays the operation contained in the message to the resource
provider manager.
Diffs (updated)
-----
src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
src/slave/slave.hpp aea1e948209c7c8945665915bc2f6d8eb47814ef
src/slave/slave.cpp d8477b4e364270f5ad61311aa8fe48f823bc7aac
Diff: https://reviews.apache.org/r/61947/diff/4/
Changes: https://reviews.apache.org/r/61947/diff/3-4/
Testing
-------
make check
Thanks,
Jan Schlicht