You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/08/02 07:24:58 UTC
Re: Review Request 71150: Factored out storage provider method to
update resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71150/#review216947
-----------------------------------------------------------
I'm not sure if this is
src/resource_provider/storage/provider.cpp
Lines 292 (patched)
<https://reviews.apache.org/r/71150/#comment304250>
Did you accidentally add a new line?
src/resource_provider/storage/provider.cpp
Lines 728 (patched)
<https://reviews.apache.org/r/71150/#comment304270>
How about merging this function and `reconcileStoragePools` since the logic is very similar?
src/resource_provider/storage/provider.cpp
Lines 730 (patched)
<https://reviews.apache.org/r/71150/#comment304182>
Remove this debug log.
src/resource_provider/storage/provider.cpp
Lines 735 (patched)
<https://reviews.apache.org/r/71150/#comment304183>
Remove this debug log.
- Chun-Hung Hsiao
On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71150/
> -----------------------------------------------------------
>
> (Updated July 23, 2019, 8:18 p.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Factored out storage provider method to update resources.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp 6d632606f411d3ca99d3573a57c9f68b02ba8072
>
>
> Diff: https://reviews.apache.org/r/71150/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71150: Factored out storage provider method to
update resources.
Posted by Benjamin Bannier <bb...@apache.org>.
> On Aug. 2, 2019, 9:24 a.m., Chun-Hung Hsiao wrote:
> > I'm not sure if this is
Could you rephrase that?
> On Aug. 2, 2019, 9:24 a.m., Chun-Hung Hsiao wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 730 (patched)
> > <https://reviews.apache.org/r/71150/diff/1/?file=2157525#file2157525line730>
> >
> > Remove this debug log.
Moved the removal in https://reviews.apache.org/r/71151/ here.
> On Aug. 2, 2019, 9:24 a.m., Chun-Hung Hsiao wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 735 (patched)
> > <https://reviews.apache.org/r/71150/diff/1/?file=2157525#file2157525line735>
> >
> > Remove this debug log.
Moved the removal in https://reviews.apache.org/r/71151/ here.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71150/#review216947
-----------------------------------------------------------
On July 23, 2019, 10:18 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71150/
> -----------------------------------------------------------
>
> (Updated July 23, 2019, 10:18 p.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Factored out storage provider method to update resources.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp 6d632606f411d3ca99d3573a57c9f68b02ba8072
>
>
> Diff: https://reviews.apache.org/r/71150/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>