You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/07 01:29:48 UTC
[GitHub] TisonKun commented on a change in pull request #7640: [FLINK-11512]
Port CliFrontendModifyTest to new code base
TisonKun commented on a change in pull request #7640: [FLINK-11512] Port CliFrontendModifyTest to new code base
URL: https://github.com/apache/flink/pull/7640#discussion_r254519007
##########
File path: flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendModifyTest.java
##########
@@ -115,13 +115,12 @@ public void testUnparsableJobId() throws Exception {
return rescaleJobFuture.get();
}
- private static final class TestingClusterClient extends StandaloneClusterClient {
+ private static final class TestingClusterClient extends RestClusterClient<StandaloneClusterId> {
Review comment:
[Stephan Ewen on ML](https://lists.apache.org/thread.html/cc46fde6f8b31d4e833b01e5814a9547c8a67ea3e08a31ec5d71145e@%3Cdev.flink.apache.org%3E) mentioned that we will finally use a HTTP client. Thus we can only check `RestClusteClient`.
Also [FLINK-11540](https://issues.apache.org/jira/browse/FLINK-11540) intends to remove `StandaloneClusterClient` since it is legacy now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services