[GitHub] [incubator-superset] rusackas commented on a change in pull request #12122: refactor: Migrate Bootstrap Alert to AntD (#12101)

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #12122:
URL: https://github.com/apache/incubator-superset/pull/12122#discussion_r546055982



##########
File path: superset-frontend/spec/javascripts/messageToasts/components/Toast_spec.jsx
##########
@@ -31,32 +30,27 @@ const props = {
 const setup = overrideProps => mount(<Toast {...props} {...overrideProps} />);
 
 describe('Toast', () => {
-  it('should render an Alert', () => {
+  it('should render', () => {
     const wrapper = setup();
-    expect(wrapper.find(Alert)).toExist();
+    expect(wrapper.find('div')).toExist();

Review comment:
       It might be good to make these a little more specific, like perhaps a `data-test` attribute




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org