You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Chris Male (JIRA)" <ji...@apache.org> on 2012/05/09 02:55:50 UTC
[jira] [Created] (LUCENE-4044) Add NamedSPILoader support to
TokenizerFactory, TokenFilterFactory and CharFilterFactory
Chris Male created LUCENE-4044:
----------------------------------
Summary: Add NamedSPILoader support to TokenizerFactory, TokenFilterFactory and CharFilterFactory
Key: LUCENE-4044
URL: https://issues.apache.org/jira/browse/LUCENE-4044
Project: Lucene - Java
Issue Type: Sub-task
Components: modules/analysis
Reporter: Chris Male
In LUCENE-2510 I want to move all the analysis factories out of Solr and into the directories with what they create. This is going to hamper Solr's existing strategy for supporting {{solr.*}} package names, where it replaces {{solr}} with various pre-defined package names. One way to tackle this is to use NamedSPILoader so we simply look up {{StandardTokenizerFactory}} for example, and find it wherever it is, as long as it is defined as a service. This is similar to how we support Codecs currently.
As noted by Robert in LUCENE-2510, this would also have the benefit of meaning configurations could be less verbose, would aid in fully decoupling the analysis module from Solr, and make the analysis factories easier to interact with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4044) Add NamedSPILoader support to
TokenizerFactory, TokenFilterFactory and CharFilterFactory
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271024#comment-13271024 ]
Chris Male commented on LUCENE-4044:
------------------------------------
With that said, I'm open to suggestions since I dont think this is going to do what I want it to do.
> Add NamedSPILoader support to TokenizerFactory, TokenFilterFactory and CharFilterFactory
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-4044
> URL: https://issues.apache.org/jira/browse/LUCENE-4044
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: modules/analysis
> Reporter: Chris Male
> Fix For: 4.0
>
>
> In LUCENE-2510 I want to move all the analysis factories out of Solr and into the directories with what they create. This is going to hamper Solr's existing strategy for supporting {{solr.*}} package names, where it replaces {{solr}} with various pre-defined package names. One way to tackle this is to use NamedSPILoader so we simply look up {{StandardTokenizerFactory}} for example, and find it wherever it is, as long as it is defined as a service. This is similar to how we support Codecs currently.
> As noted by Robert in LUCENE-2510, this would also have the benefit of meaning configurations could be less verbose, would aid in fully decoupling the analysis module from Solr, and make the analysis factories easier to interact with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4044) Add NamedSPILoader support to
TokenizerFactory, TokenFilterFactory and CharFilterFactory
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271159#comment-13271159 ]
Robert Muir commented on LUCENE-4044:
-------------------------------------
why is it a problem? You just put the .class instance instead.
> Add NamedSPILoader support to TokenizerFactory, TokenFilterFactory and CharFilterFactory
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-4044
> URL: https://issues.apache.org/jira/browse/LUCENE-4044
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: modules/analysis
> Reporter: Chris Male
> Fix For: 4.0
>
>
> In LUCENE-2510 I want to move all the analysis factories out of Solr and into the directories with what they create. This is going to hamper Solr's existing strategy for supporting {{solr.*}} package names, where it replaces {{solr}} with various pre-defined package names. One way to tackle this is to use NamedSPILoader so we simply look up {{StandardTokenizerFactory}} for example, and find it wherever it is, as long as it is defined as a service. This is similar to how we support Codecs currently.
> As noted by Robert in LUCENE-2510, this would also have the benefit of meaning configurations could be less verbose, would aid in fully decoupling the analysis module from Solr, and make the analysis factories easier to interact with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4044) Add NamedSPILoader support to
TokenizerFactory, TokenFilterFactory and CharFilterFactory
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271020#comment-13271020 ]
Chris Male commented on LUCENE-4044:
------------------------------------
There will be alot of different packages, I assumed that cycling through them all would be undesirable.
> Add NamedSPILoader support to TokenizerFactory, TokenFilterFactory and CharFilterFactory
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-4044
> URL: https://issues.apache.org/jira/browse/LUCENE-4044
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: modules/analysis
> Reporter: Chris Male
> Fix For: 4.0
>
>
> In LUCENE-2510 I want to move all the analysis factories out of Solr and into the directories with what they create. This is going to hamper Solr's existing strategy for supporting {{solr.*}} package names, where it replaces {{solr}} with various pre-defined package names. One way to tackle this is to use NamedSPILoader so we simply look up {{StandardTokenizerFactory}} for example, and find it wherever it is, as long as it is defined as a service. This is similar to how we support Codecs currently.
> As noted by Robert in LUCENE-2510, this would also have the benefit of meaning configurations could be less verbose, would aid in fully decoupling the analysis module from Solr, and make the analysis factories easier to interact with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4044) Add NamedSPILoader support to
TokenizerFactory, TokenFilterFactory and CharFilterFactory
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271017#comment-13271017 ]
Yonik Seeley commented on LUCENE-4044:
--------------------------------------
bq. This is going to hamper Solr's existing strategy for supporting solr.* package names
Why is that? Why can't solr.WhitespaceTokenizerFactory also check the package that you're planning on moving WhitespaceTokenizerFactory to?
> Add NamedSPILoader support to TokenizerFactory, TokenFilterFactory and CharFilterFactory
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-4044
> URL: https://issues.apache.org/jira/browse/LUCENE-4044
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: modules/analysis
> Reporter: Chris Male
> Fix For: 4.0
>
>
> In LUCENE-2510 I want to move all the analysis factories out of Solr and into the directories with what they create. This is going to hamper Solr's existing strategy for supporting {{solr.*}} package names, where it replaces {{solr}} with various pre-defined package names. One way to tackle this is to use NamedSPILoader so we simply look up {{StandardTokenizerFactory}} for example, and find it wherever it is, as long as it is defined as a service. This is similar to how we support Codecs currently.
> As noted by Robert in LUCENE-2510, this would also have the benefit of meaning configurations could be less verbose, would aid in fully decoupling the analysis module from Solr, and make the analysis factories easier to interact with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4044) Add NamedSPILoader support to
TokenizerFactory, TokenFilterFactory and CharFilterFactory
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271228#comment-13271228 ]
Chris Male commented on LUCENE-4044:
------------------------------------
I'm not really sure how to do that, since the service has to implement NamedSPILoader.NamedSPI.
> Add NamedSPILoader support to TokenizerFactory, TokenFilterFactory and CharFilterFactory
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-4044
> URL: https://issues.apache.org/jira/browse/LUCENE-4044
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: modules/analysis
> Reporter: Chris Male
> Fix For: 4.0
>
>
> In LUCENE-2510 I want to move all the analysis factories out of Solr and into the directories with what they create. This is going to hamper Solr's existing strategy for supporting {{solr.*}} package names, where it replaces {{solr}} with various pre-defined package names. One way to tackle this is to use NamedSPILoader so we simply look up {{StandardTokenizerFactory}} for example, and find it wherever it is, as long as it is defined as a service. This is similar to how we support Codecs currently.
> As noted by Robert in LUCENE-2510, this would also have the benefit of meaning configurations could be less verbose, would aid in fully decoupling the analysis module from Solr, and make the analysis factories easier to interact with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4044) Add NamedSPILoader support to
TokenizerFactory, TokenFilterFactory and CharFilterFactory
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271055#comment-13271055 ]
Chris Male commented on LUCENE-4044:
------------------------------------
Hmm it seems that this process only supports singletons, which isn't much use to us.
> Add NamedSPILoader support to TokenizerFactory, TokenFilterFactory and CharFilterFactory
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-4044
> URL: https://issues.apache.org/jira/browse/LUCENE-4044
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: modules/analysis
> Reporter: Chris Male
> Fix For: 4.0
>
>
> In LUCENE-2510 I want to move all the analysis factories out of Solr and into the directories with what they create. This is going to hamper Solr's existing strategy for supporting {{solr.*}} package names, where it replaces {{solr}} with various pre-defined package names. One way to tackle this is to use NamedSPILoader so we simply look up {{StandardTokenizerFactory}} for example, and find it wherever it is, as long as it is defined as a service. This is similar to how we support Codecs currently.
> As noted by Robert in LUCENE-2510, this would also have the benefit of meaning configurations could be less verbose, would aid in fully decoupling the analysis module from Solr, and make the analysis factories easier to interact with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org