You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/23 01:05:47 UTC
[GitHub] [hudi] danny0405 commented on a diff in pull request #6149: [HUDI-4426] The implementation of Clean is inconsistent with CLEANER_COMMITS_RETAINED
danny0405 commented on code in PR #6149:
URL: https://github.com/apache/hudi/pull/6149#discussion_r928058973
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanner.java:
##########
@@ -401,12 +401,12 @@ private List<CleanFileInfo> getReplacedFilesEligibleToClean(List<String> savepoi
}
/**
- * Gets the latest version < instantTime. This version file could still be used by queries.
+ * Gets the latest version <= instantTime. This version file could still be used by queries.
*/
private String getLatestVersionBeforeCommit(List<FileSlice> fileSliceList, HoodieInstant instantTime) {
for (FileSlice file : fileSliceList) {
String fileCommitTime = file.getBaseInstantTime();
Review Comment:
The method name indicates `before` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org