You are viewing a plain text version of this content. The canonical link for it is here.
Posted to olio-dev@incubator.apache.org by "Shanti Subramanyam (JIRA)" <ji...@apache.org> on 2009/06/23 17:28:07 UTC

[jira] Created: (OLIO-109) timezone fields in schema are inconsistent

timezone fields in schema are inconsistent
------------------------------------------

                 Key: OLIO-109
                 URL: https://issues.apache.org/jira/browse/OLIO-109
             Project: Olio
          Issue Type: Bug
          Components: generic
    Affects Versions: 0.1
            Reporter: Shanti Subramanyam
            Assignee: Shanti Subramanyam
            Priority: Minor
             Fix For: 0.2


Jim Larus reports:
In the schema for the DB, the timezone in the PERSON class is a 25-char string, while the timezone field in SOCIALEVENT is 100-char string. Some of the timezones in includes/timezones.html are longer than 25 char, so I suspect the latter is correct.

Both the php and rails schema use a 25-char string in PERSON, where as the Java app uses 255 (which is probably an overkill). Only the PHP app has timezone in the SOCIALEVENT table - the other two apps don't.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OLIO-109) timezone fields in schema are inconsistent

Posted by "Kim LiChong (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OLIO-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759305#action_12759305 ] 

Kim LiChong commented on OLIO-109:
----------------------------------

Current bug fix causes SQL DatabaseException
Internal Exception: com.mysql.jdbc.exceptions.MySQLSyntaxErrorException: Unknown column 'TIMEZONE' in 'field list'
Error Code: 1054

Need to remove timezone field in SocialEvent as JPA looks for this field in database.  The timezone adjustment is made in EventRestAction.java

See Related bug  Olio-Issue 118
Committed revision 818648.

> timezone fields in schema are inconsistent
> ------------------------------------------
>
>                 Key: OLIO-109
>                 URL: https://issues.apache.org/jira/browse/OLIO-109
>             Project: Olio
>          Issue Type: Bug
>          Components: generic
>    Affects Versions: 0.1
>            Reporter: Shanti Subramanyam
>            Assignee: Shanti Subramanyam
>            Priority: Minor
>             Fix For: 0.3
>
>
> Jim Larus reports:
> In the schema for the DB, the timezone in the PERSON class is a 25-char string, while the timezone field in SOCIALEVENT is 100-char string. Some of the timezones in includes/timezones.html are longer than 25 char, so I suspect the latter is correct.
> Both the php and rails schema use a 25-char string in PERSON, where as the Java app uses 255 (which is probably an overkill). Only the PHP app has timezone in the SOCIALEVENT table - the other two apps don't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OLIO-109) timezone fields in schema are inconsistent

Posted by "Kim LiChong (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OLIO-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755274#action_12755274 ] 

Kim LiChong commented on OLIO-109:
----------------------------------

For the Java application, a Java TimeStamp is used for the createdTimestamp and the eventTimestamp which is a wrapper class for java.util.Date which encompasses timezone information.  As such, it does not require a separate timezone database field in the database.  The application accepts the desired timezone and sets this in the Timestamp object.   Related is bug OLIO-118 where the socialevent timezone was always being stored as the system default and the user was incapable of setting the appropriate timezone.

The timezone field in Java has been corrected and will be checked in with the loader integration in 0.2 release.

The event times should be displayed according to the timezone stored for the Person object.  This needs to be corrected in the java application based on bug OLIO-118 since a current scan of the DB shows all person have a PST as the timezone.

> timezone fields in schema are inconsistent
> ------------------------------------------
>
>                 Key: OLIO-109
>                 URL: https://issues.apache.org/jira/browse/OLIO-109
>             Project: Olio
>          Issue Type: Bug
>          Components: generic
>    Affects Versions: 0.1
>            Reporter: Shanti Subramanyam
>            Assignee: Shanti Subramanyam
>            Priority: Minor
>             Fix For: 0.3
>
>
> Jim Larus reports:
> In the schema for the DB, the timezone in the PERSON class is a 25-char string, while the timezone field in SOCIALEVENT is 100-char string. Some of the timezones in includes/timezones.html are longer than 25 char, so I suspect the latter is correct.
> Both the php and rails schema use a 25-char string in PERSON, where as the Java app uses 255 (which is probably an overkill). Only the PHP app has timezone in the SOCIALEVENT table - the other two apps don't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OLIO-109) timezone fields in schema are inconsistent

Posted by "Shanti Subramanyam (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OLIO-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shanti Subramanyam updated OLIO-109:
------------------------------------

    Fix Version/s:     (was: 0.2)
                   0.3

There are many more schema inconsistencies between the versions, so postponing this to 0.3 or beyond.

> timezone fields in schema are inconsistent
> ------------------------------------------
>
>                 Key: OLIO-109
>                 URL: https://issues.apache.org/jira/browse/OLIO-109
>             Project: Olio
>          Issue Type: Bug
>          Components: generic
>    Affects Versions: 0.1
>            Reporter: Shanti Subramanyam
>            Assignee: Shanti Subramanyam
>            Priority: Minor
>             Fix For: 0.3
>
>
> Jim Larus reports:
> In the schema for the DB, the timezone in the PERSON class is a 25-char string, while the timezone field in SOCIALEVENT is 100-char string. Some of the timezones in includes/timezones.html are longer than 25 char, so I suspect the latter is correct.
> Both the php and rails schema use a 25-char string in PERSON, where as the Java app uses 255 (which is probably an overkill). Only the PHP app has timezone in the SOCIALEVENT table - the other two apps don't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (OLIO-109) timezone fields in schema are inconsistent

Posted by Kim LiChong <Ki...@Sun.COM>.
Hi James,

Sorry this is my bug.  As stated in Olio-118, the timezone field is not 
necessary in the schema however SocialEvent still needs a timezone field 
so that the user has the ability record an event in another timezone 
than his preferred one.  The bug arises because JPA is looking for a 
timezone field in the table but this information will be stored in the 
TimeStamp field.

I'll update the bug and provide a fix as necessary.

Thanks,

Kim
>     [ https://issues.apache.org/jira/browse/OLIO-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759181#action_12759181 ] 
>
> James Zubb commented on OLIO-109:
> ---------------------------------
>
> I am not able to get the OLIO-118 changes to work with the current Java DB schema, the error I get seems to imply to me that there needs to be a TIMEZONE field in DB, but you mention it is not needed, did I configure something incorrectly?
>
> I get the error:
>
> Exception [EclipseLink-4002] (Eclipse Persistence Services - 1.1.2.v20090612-r4475): org.eclipse.persistence.exceptions.
> DatabaseException
> Internal Exception: com.mysql.jdbc.exceptions.MySQLSyntaxErrorException: Unknown column 'TIMEZONE' in 'field list'
> Error Code: 1054
> Call: SELECT SOCIALEVENTID AS SOCIALEVENTID1, SUMMARY AS SUMMARY2, TOTALSCORE AS TOTALSCORE3, CREATEDTIMESTAMP AS CREATE
> DTIMESTAMP4, EVENTTIMESTAMP AS EVENTTIMESTAMP5, IMAGETHUMBURL AS IMAGETHUMBURL6, NUMBEROFVOTES AS NUMBEROFVOTES7, TITLE
> AS TITLE8, TIMEZONE AS TIMEZONE9, DESCRIPTION AS DESCRIPTION10, TELEPHONE AS TELEPHONE11, LITERATUREURL AS LITERATUREURL
> 12, SUBMITTERUSERNAME AS SUBMITTERUSERNAME13, DISABLED AS DISABLED14, IMAGEURL AS IMAGEURL15, ADDRESS_ADDRESSID AS ADDRE
> SS_ADDRESSID16 FROM SOCIALEVENT WHERE (EVENTTIMESTAMP >= CURRENT_TIMESTAMP) ORDER BY EVENTTIMESTAMP ASC LIMIT ?, ?
>         bind => [0, 10]
> Query: ReadAllQuery(referenceClass=SocialEvent sql="SELECT SOCIALEVENTID AS SOCIALEVENTID1, SUMMARY AS SUMMARY2, TOTALSC
> ORE AS TOTALSCORE3, CREATEDTIMESTAMP AS CREATEDTIMESTAMP4, EVENTTIMESTAMP AS EVENTTIMESTAMP5, IMAGETHUMBURL AS IMAGETHUM
> BURL6, NUMBEROFVOTES AS NUMBEROFVOTES7, TITLE AS TITLE8, TIMEZONE AS TIMEZONE9, DESCRIPTION AS DESCRIPTION10, TELEPHONE
> AS TELEPHONE11, LITERATUREURL AS LITERATUREURL12, SUBMITTERUSERNAME AS SUBMITTERUSERNAME13, DISABLED AS DISABLED14, IMAG
> EURL AS IMAGEURL15, ADDRESS_ADDRESSID AS ADDRESS_ADDRESSID16 FROM SOCIALEVENT WHERE (EVENTTIMESTAMP >= CURRENT_TIMESTAMP
> ) ORDER BY EVENTTIMESTAMP ASC LIMIT ?, ?")
> ...
>
>
> Backing out the changes made in OLIO-118 fixed the errors I was getting.
>
>   
>> timezone fields in schema are inconsistent
>> ------------------------------------------
>>
>>                 Key: OLIO-109
>>                 URL: https://issues.apache.org/jira/browse/OLIO-109
>>             Project: Olio
>>          Issue Type: Bug
>>          Components: generic
>>    Affects Versions: 0.1
>>            Reporter: Shanti Subramanyam
>>            Assignee: Shanti Subramanyam
>>            Priority: Minor
>>             Fix For: 0.3
>>
>>
>> Jim Larus reports:
>> In the schema for the DB, the timezone in the PERSON class is a 25-char string, while the timezone field in SOCIALEVENT is 100-char string. Some of the timezones in includes/timezones.html are longer than 25 char, so I suspect the latter is correct.
>> Both the php and rails schema use a 25-char string in PERSON, where as the Java app uses 255 (which is probably an overkill). Only the PHP app has timezone in the SOCIALEVENT table - the other two apps don't.
>>     
>
>   


[jira] Commented: (OLIO-109) timezone fields in schema are inconsistent

Posted by "James Zubb (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OLIO-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759181#action_12759181 ] 

James Zubb commented on OLIO-109:
---------------------------------

I am not able to get the OLIO-118 changes to work with the current Java DB schema, the error I get seems to imply to me that there needs to be a TIMEZONE field in DB, but you mention it is not needed, did I configure something incorrectly?

I get the error:

Exception [EclipseLink-4002] (Eclipse Persistence Services - 1.1.2.v20090612-r4475): org.eclipse.persistence.exceptions.
DatabaseException
Internal Exception: com.mysql.jdbc.exceptions.MySQLSyntaxErrorException: Unknown column 'TIMEZONE' in 'field list'
Error Code: 1054
Call: SELECT SOCIALEVENTID AS SOCIALEVENTID1, SUMMARY AS SUMMARY2, TOTALSCORE AS TOTALSCORE3, CREATEDTIMESTAMP AS CREATE
DTIMESTAMP4, EVENTTIMESTAMP AS EVENTTIMESTAMP5, IMAGETHUMBURL AS IMAGETHUMBURL6, NUMBEROFVOTES AS NUMBEROFVOTES7, TITLE
AS TITLE8, TIMEZONE AS TIMEZONE9, DESCRIPTION AS DESCRIPTION10, TELEPHONE AS TELEPHONE11, LITERATUREURL AS LITERATUREURL
12, SUBMITTERUSERNAME AS SUBMITTERUSERNAME13, DISABLED AS DISABLED14, IMAGEURL AS IMAGEURL15, ADDRESS_ADDRESSID AS ADDRE
SS_ADDRESSID16 FROM SOCIALEVENT WHERE (EVENTTIMESTAMP >= CURRENT_TIMESTAMP) ORDER BY EVENTTIMESTAMP ASC LIMIT ?, ?
        bind => [0, 10]
Query: ReadAllQuery(referenceClass=SocialEvent sql="SELECT SOCIALEVENTID AS SOCIALEVENTID1, SUMMARY AS SUMMARY2, TOTALSC
ORE AS TOTALSCORE3, CREATEDTIMESTAMP AS CREATEDTIMESTAMP4, EVENTTIMESTAMP AS EVENTTIMESTAMP5, IMAGETHUMBURL AS IMAGETHUM
BURL6, NUMBEROFVOTES AS NUMBEROFVOTES7, TITLE AS TITLE8, TIMEZONE AS TIMEZONE9, DESCRIPTION AS DESCRIPTION10, TELEPHONE
AS TELEPHONE11, LITERATUREURL AS LITERATUREURL12, SUBMITTERUSERNAME AS SUBMITTERUSERNAME13, DISABLED AS DISABLED14, IMAG
EURL AS IMAGEURL15, ADDRESS_ADDRESSID AS ADDRESS_ADDRESSID16 FROM SOCIALEVENT WHERE (EVENTTIMESTAMP >= CURRENT_TIMESTAMP
) ORDER BY EVENTTIMESTAMP ASC LIMIT ?, ?")
...


Backing out the changes made in OLIO-118 fixed the errors I was getting.

> timezone fields in schema are inconsistent
> ------------------------------------------
>
>                 Key: OLIO-109
>                 URL: https://issues.apache.org/jira/browse/OLIO-109
>             Project: Olio
>          Issue Type: Bug
>          Components: generic
>    Affects Versions: 0.1
>            Reporter: Shanti Subramanyam
>            Assignee: Shanti Subramanyam
>            Priority: Minor
>             Fix For: 0.3
>
>
> Jim Larus reports:
> In the schema for the DB, the timezone in the PERSON class is a 25-char string, while the timezone field in SOCIALEVENT is 100-char string. Some of the timezones in includes/timezones.html are longer than 25 char, so I suspect the latter is correct.
> Both the php and rails schema use a 25-char string in PERSON, where as the Java app uses 255 (which is probably an overkill). Only the PHP app has timezone in the SOCIALEVENT table - the other two apps don't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (OLIO-109) timezone fields in schema are inconsistent

Posted by "Kim LiChong (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OLIO-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim LiChong resolved OLIO-109.
------------------------------

    Resolution: Fixed

> timezone fields in schema are inconsistent
> ------------------------------------------
>
>                 Key: OLIO-109
>                 URL: https://issues.apache.org/jira/browse/OLIO-109
>             Project: Olio
>          Issue Type: Bug
>          Components: generic
>    Affects Versions: 0.1
>            Reporter: Shanti Subramanyam
>            Assignee: Shanti Subramanyam
>            Priority: Minor
>             Fix For: 0.3
>
>
> Jim Larus reports:
> In the schema for the DB, the timezone in the PERSON class is a 25-char string, while the timezone field in SOCIALEVENT is 100-char string. Some of the timezones in includes/timezones.html are longer than 25 char, so I suspect the latter is correct.
> Both the php and rails schema use a 25-char string in PERSON, where as the Java app uses 255 (which is probably an overkill). Only the PHP app has timezone in the SOCIALEVENT table - the other two apps don't.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.