You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tzolov <gi...@git.apache.org> on 2015/08/10 14:24:28 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-216: Update ACE version,...
GitHub user tzolov opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/200
ZEPPELIN-216: Update ACE version, Change theme from Github to Chrome, add 'SH' mode.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzolov/incubator-zeppelin ZEPPELIN-216
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/200.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #200
----
commit 114756c597303694e77b4564a3c1a23e5bd12546
Author: tzolov <ch...@gmail.com>
Date: 2015-08-06T07:36:47Z
ZEPPELIN-141: Show only the Interpreters suggestions. Move the 'local' suggestions to the bottom of the list
commit f9ff609e959cbdd2897325dc2acd19a86e2380d1
Author: tzolov <ch...@gmail.com>
Date: 2015-08-08T08:45:07Z
ZEPPELIN-141: Add the default langToos (keyWord,snippet,text)Completers after the Interpter one
commit 78117e63509792700b571a4f9e6f5d88e4e411ab
Author: tzolov <ch...@gmail.com>
Date: 2015-08-08T19:25:53Z
ZEPPELIN-141: (Re)set the correct ACE editor mode on auto-completion event (Ctrl+.)
commit a7202a7de6108dd7a047103e3d7c85bf2ae15c5b
Author: tzolov <ch...@gmail.com>
Date: 2015-08-08T19:28:18Z
ZEPPELIN-141: resolve ACE auto-completion pop-up menu wrong z-index
commit 04b88c8d7b3807e210b3046d6da7019d3d2cb20f
Author: tzolov <ch...@gmail.com>
Date: 2015-08-07T00:09:42Z
ZEPPELIN-216: Set Update ACE-Build to 1.1.9; Change theme to Chrome; Add SH syntax mode
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-216: Update ACE version,...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/200#issuecomment-129427581
In the first version i have:
* upgraded ACE from 1.1.8 to 1.1.9
* changed the theme from `github` to `chrome`
* added `sh` editor mode
Below are some sample screenshots of the same notes before and after the change:
#### Spark + SparkSQL Before:
<img width="927" alt="spark-before" src="https://cloud.githubusercontent.com/assets/1351573/9171429/b5e1eb7c-3f6b-11e5-9d28-843997c7a34b.png">
#### Spark + SparkSQL After:
<img width="924" alt="spark-after" src="https://cloud.githubusercontent.com/assets/1351573/9171428/b5de7690-3f6b-11e5-8ae0-f0f785ff8219.png">
#### PostgreSQL Before:
<img width="1379" alt="psql-before" src="https://cloud.githubusercontent.com/assets/1351573/9171467/0bbfc992-3f6c-11e5-9433-f7a96c40bd52.png">
#### PostgreSQL After:
<img width="1022" alt="psql-after" src="https://cloud.githubusercontent.com/assets/1351573/9171472/1f261e8c-3f6c-11e5-8aff-24969db06f6a.png">
#### SH Before:
<img width="682" alt="sh-before" src="https://cloud.githubusercontent.com/assets/1351573/9171483/2f016550-3f6c-11e5-9e78-37715572f0ac.png">
#### SH After:
<img width="679" alt="sh-after" src="https://cloud.githubusercontent.com/assets/1351573/9171488/3b5ba93c-3f6c-11e5-8f81-cb178961b655.png">
#### Geode OQL Before:
<img width="1299" alt="geode-oql-before" src="https://cloud.githubusercontent.com/assets/1351573/9171504/62f22250-3f6c-11e5-99cd-8577a6d648a4.png">
#### Geode OQL After:
<img width="1334" alt="geode-oql-after" src="https://cloud.githubusercontent.com/assets/1351573/9171508/698775d4-3f6c-11e5-841c-cb916b906c2a.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-216: Update ACE version,...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/200#issuecomment-130364038
Tested and Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-216: Update ACE version,...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/200
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---