[GitHub] [incubator-kyuubi] lightning-L commented on pull request #2459: [KYUUBI #1936][FOLLOWUP] stop updating credentials when credentials a…

[GitBox <gi...@apache.org>]

lightning-L commented on PR #2459:
URL: https://github.com/apache/incubator-kyuubi/pull/2459#issuecomment-1107810912

   Sorry for the late commit.
   
   This is the follow-up for the comments in https://github.com/apache/incubator-kyuubi/pull/2210 
   ------
   But considering the following scenario, I think we should also check whether userRef in `userCredentialsRefMap` has been replaced by a new one .
   
   `userRef` was waiting for next renewal.
   `userRef` expired and was removed from `userCredentialsRefMap`
   A new `userRef` was created because of user visiting.
   Renewal of old userRef started again.
   If we do not check, both old and new userRef will renew periodically.
   
   modified the code and added test case for the scenario.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org