You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/05/19 10:42:29 UTC
Review Request 59395: RANGER-1593 - Avoid Classloading default
AtlasResourceMappers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59395/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-1593
https://issues.apache.org/jira/browse/RANGER-1593
Repository: ranger
Description
-------
In AtlasResourceMapperUtil we classload both the default AtlasResourceMappers and then the custom ones. This is unnecessary - we should just instantiate the default ones and classload the custom ones.
Diffs
-----
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java 5227d8c3
Diff: https://reviews.apache.org/r/59395/diff/1/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 59395: RANGER-1593 - Avoid Classloading default
AtlasResourceMappers
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59395/#review175611
-----------------------------------------------------------
Please rebuild the patch to fixed the following message.
.git/rebase-apply/patch:13: trailing whitespace.
.git/rebase-apply/patch:44: trailing whitespace.
.git/rebase-apply/patch:67: space before tab in indent.
try {
.git/rebase-apply/patch:68: space before tab in indent.
Class<?> clazz = Class.forName(customMapperName);
.git/rebase-apply/patch:69: space before tab in indent.
AtlasResourceMapper resourceMapper = (AtlasResourceMapper) clazz.newInstance();
warning: squelched 7 whitespace errors
warning: 12 lines add whitespace errors.
- Qiang Zhang
On 五月 19, 2017, 10:42 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59395/
> -----------------------------------------------------------
>
> (Updated 五月 19, 2017, 10:42 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1593
> https://issues.apache.org/jira/browse/RANGER-1593
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In AtlasResourceMapperUtil we classload both the default AtlasResourceMappers and then the custom ones. This is unnecessary - we should just instantiate the default ones and classload the custom ones.
>
>
> Diffs
> -----
>
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java 5227d8c3
>
>
> Diff: https://reviews.apache.org/r/59395/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 59395: RANGER-1593 - Avoid Classloading default
AtlasResourceMappers
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59395/#review175890
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On 五月 22, 2017, 9:46 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59395/
> -----------------------------------------------------------
>
> (Updated 五月 22, 2017, 9:46 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1593
> https://issues.apache.org/jira/browse/RANGER-1593
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In AtlasResourceMapperUtil we classload both the default AtlasResourceMappers and then the custom ones. This is unnecessary - we should just instantiate the default ones and classload the custom ones.
>
>
> Diffs
> -----
>
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java 5227d8c3
>
>
> Diff: https://reviews.apache.org/r/59395/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 59395: RANGER-1593 - Avoid Classloading default
AtlasResourceMappers
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59395/
-----------------------------------------------------------
(Updated May 22, 2017, 9:46 a.m.)
Review request for ranger.
Changes
-------
Fixing whitespace
Bugs: RANGER-1593
https://issues.apache.org/jira/browse/RANGER-1593
Repository: ranger
Description
-------
In AtlasResourceMapperUtil we classload both the default AtlasResourceMappers and then the custom ones. This is unnecessary - we should just instantiate the default ones and classload the custom ones.
Diffs (updated)
-----
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java 5227d8c3
Diff: https://reviews.apache.org/r/59395/diff/2/
Changes: https://reviews.apache.org/r/59395/diff/1-2/
Testing
-------
Thanks,
Colm O hEigeartaigh